From 62f87acb46a92b43b28917524ef12d7c3357639d Mon Sep 17 00:00:00 2001 From: "W. Trevor King" Date: Fri, 24 Aug 2018 15:22:12 -0700 Subject: [PATCH] OWNERS_ALIASES: Define aliases for reviewers and approvers This will make it easier to add special-case OWNERS files to openshift/release while still getting the members slurped up with the populate-owners tooling. That tooling pulls OWNERS_ALIASES since openshift/release@e1f993fb (populate-owners: Also slurp OWNERS_ALIASES, 2018-08-25, openshift/release#1285). --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- CONTRIBUTING.md | 2 +- OWNERS | 10 +++------- OWNERS_ALIASES | 12 ++++++++++++ tests/README.md | 2 +- 5 files changed, 18 insertions(+), 10 deletions(-) create mode 100644 OWNERS_ALIASES diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 3aad222c380..87df3487691 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,4 +1,4 @@ Before creating your PR, please make sure to add the appropriate GitHub label; i.e. `run-smoke-tests`. For more details see [tests/README.md](../tests/README.md). -(In case you don't have permissions to add labels, please ask a [maintainer](../OWNERS).) +(In case you don't have permissions to add labels, please ask [a](../OWNERS) [maintainer](../OWNERS_ALIASES).) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d0f59155e60..d77e36eccc8 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -44,7 +44,7 @@ For contributors who want to work up pull requests, the workflow is roughly: ``` Note that a portion of the docs and examples are generated and that the generated files are to be committed by you. `make structure-check` checks that what is generated is what you must commit. 7. Submit a pull request to the original repository. -8. The [repo owners](OWNERS) will respond to your issue promptly, following [the ususal Prow workflow][prow-review]. +8. The [repo](OWNERS) [owners](OWNERS_ALIASES) will respond to your issue promptly, following [the ususal Prow workflow][prow-review]. Thanks for your contributions! diff --git a/OWNERS b/OWNERS index ead2bf30b1f..07b6cb50585 100644 --- a/OWNERS +++ b/OWNERS @@ -1,11 +1,7 @@ # See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md +# This file just uses aliases defined in OWNERS_ALIASES. approvers: - - aaronlevy - - abhinavdahiya - - crawford - - smarterclayton - - wking - - yifan-gu + - installer-approvers reviewers: - - vikramsk + - installer-reviewers diff --git a/OWNERS_ALIASES b/OWNERS_ALIASES new file mode 100644 index 00000000000..88f40717c29 --- /dev/null +++ b/OWNERS_ALIASES @@ -0,0 +1,12 @@ +# See the OWNERS_ALIASES docs: https://git.k8s.io/community/contributors/guide/owners.md#OWNERS_ALIASES + +aliases: + installer-approvers: + - aaronlevy + - abhinavdahiya + - crawford + - smarterclayton + - wking + - yifan-gu + installer-reviewers: + - vikramsk diff --git a/tests/README.md b/tests/README.md index 1de1089a5a3..14fba8dfb3f 100644 --- a/tests/README.md +++ b/tests/README.md @@ -25,7 +25,7 @@ In addition to our basic set of tests we have smoke tests which are running on A ### FAQ - *I am not able to add labels, what should I do?* - Please ask one of [the repository maintainers](../OWNERS) to add the + Please ask one of the [repository](../OWNERS) [maintainers](../OWNERS_ALIASES) to add the labels. - *How do I retrigger the tests?*