Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OWNERS file #32

Closed
paulfantom opened this issue Jul 7, 2018 · 2 comments · Fixed by #71
Closed

Add OWNERS file #32

paulfantom opened this issue Jul 7, 2018 · 2 comments · Fixed by #71

Comments

@paulfantom
Copy link
Contributor

There should be an OWNERS file (like this one) to allow prow to manage who is allowed to review and/or approve PRs.
@wking
Copy link
Member

wking commented Jul 7, 2018

It would be nice if this came with docs to make it more discoverable and explain how the file fits into project governance. For example, the k8s template has a brief reference from CONTRIBUTING.md and (stale) links from the OWNERS file to upstream docs explaining how it works (kubernetes/kubernetes-template-project#15). CRI-O has a similar CONTRIBUTING.md line, which contains links to both OWNERS and (different) upstream docs.

@enxebre enxebre removed their assignment Jul 9, 2018
@wking wking mentioned this issue Jul 25, 2018
Merged
@stevekuznetsov
Copy link
Contributor

The most up-to-date documentation is here but we understand the documentation is not perfect today and we are working on making it better.

@paulfantom paulfantom mentioned this issue Jul 26, 2018
Closed
EmilienM pushed a commit to shiftstack/installer that referenced this issue Dec 8, 2020
@openshift-merge-robot
Merge pull request openshift#32 from iamemilio/OS-tags
91a4828 
Cherry Pick Upstream Changes
stbenjam pushed a commit to stbenjam/installer that referenced this issue Feb 10, 2021
@openshift-merge-robot
Merge pull request openshift#32 from asalkeld/condition-states
f8fe4e0 
Add correct condition states
mkumatag added a commit to mkumatag/installer that referenced this issue Jul 29, 2021
@mkumatag
Merge pull request openshift#32 from mkumatag/fix_dns
76f2782 
Fix the DNS record creation
zaneb pushed a commit to zaneb/openshift-installer that referenced this issue Apr 26, 2022
@openshift-merge-robot
Merge pull request openshift#32 from pawanpinjarkar/fix-makefile-targ…
6d2d79f 
…et-error

Fix format specifiers leading to makefile error
zaneb pushed a commit to zaneb/openshift-installer that referenced this issue Apr 29, 2022
@openshift-merge-robot
Merge pull request openshift#32 from pawanpinjarkar/fix-makefile-targ…
738b364 
…et-error

Fix format specifiers leading to makefile error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

OWNERS: Configure Prow with approver and reviewer information wking/openshift-installer
4 participants
@wking @enxebre @paulfantom @stevekuznetsov