Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hack/build: Pin to RHCOS 400.7.20190306.0 #1407

Merged
merged 1 commit into from Mar 13, 2019

Conversation

@wking
Copy link
Member

wking commented Mar 12, 2019

@smarterclayton pushed release:4.0.0-0.nightly-2019-03-04-234414 to quay.io/openshift-release-dev/ocp-release:4.0.0-0.7. Extracting the associated RHCOS build:

$ oc adm release info --pullspecs quay.io/openshift-release-dev/ocp-release:4.0.0-0.7 | grep machine-os-content
  machine-os-content                            quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:399582f711226ab1a0e76d8928ec55436dea9f8dc60976c10790d308b9d92181
$ oc image info quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:399582f711226ab1a0e76d8928ec55436dea9f8dc60976c10790d308b9d92181 | grep version
            version=47.330

I'd like to be pulling that version out of the release image at install-time (#1286), but that PR isn't green yet, so hard-coding here is a quick fix.

CC @abhinavdahiya, @cgwalters

@abhinavdahiya

This comment has been minimized.

Copy link
Member

abhinavdahiya commented Mar 12, 2019

/approve

Show resolved Hide resolved hack/build.sh Outdated
@cgwalters

This comment has been minimized.

Copy link
Contributor

cgwalters commented Mar 12, 2019

Very short term this is OK but soon we will need a newer version to get authenticated pivots to work.

hack/build: Pin to RHCOS 400.7.20190306.0
This is the most recent RHCOS:

  $ curl -s https://releases-rhcos.svc.ci.openshift.org/storage/releases/maipo/builds.json | jq '{"latest": .builds[0], timestamp}'
  {
    "latest": "400.7.20190306.0",
    "timestamp": "2019-03-06T22:24:53Z"
  }

I'd prefer to pull this from the release image:

  $ oc adm release info --pullspecs quay.io/openshift-release-dev/ocp-release:4.0.0-0.7 | grep machine-os-content
    machine-os-content                            quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:399582f711226ab1a0e76d8928ec55436dea9f8dc60976c10790d308b9d92181
  $ oc image info quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:399582f711226ab1a0e76d8928ec55436dea9f8dc60976c10790d308b9d92181 | grep version
              version=47.330

But [1] isn't green yet, so hard-coding here is a quick fix.

Supported regions:

  $ curl -s https://releases-rhcos.svc.ci.openshift.org/storage/releases/maipo/400.7.20190306.0/meta.json | jq -r '.amis[] | .name'
  ap-northeast-1
  ap-northeast-2
  ap-south-1
  ap-southeast-1
  ap-southeast-2
  ca-central-1
  eu-central-1
  eu-west-1
  eu-west-2
  eu-west-3
  sa-east-1
  us-east-1
  us-east-2
  us-west-1
  us-west-2

[1]: #1286

@wking wking force-pushed the wking:pin-rhcos branch from 6f7c83b to bd88157 Mar 12, 2019

@wking wking changed the title hack/build: Pin to RHCOS 47.330 hack/build: Pin to RHCOS 400.7.20190306.0 Mar 12, 2019

@wking

This comment has been minimized.

Copy link
Member Author

wking commented Mar 12, 2019

Very short term this is OK but soon we will need a newer version to get authenticated pivots to work.

Bumped to 400.7.20190306.0 with 6f7c83b -> bd88157.

@cgwalters

This comment has been minimized.

Copy link
Contributor

cgwalters commented Mar 12, 2019

/approve

@cgwalters

This comment has been minimized.

Copy link
Contributor

cgwalters commented Mar 12, 2019

This LGTM but I am going to rebase #1402 on top and also add an environment variable to select the build so we can conveniently test new versions without rebuilding the installer.

@@ -2,6 +2,8 @@

set -ex

RHCOS_BUILD_NAME="${RHCOS_BUILD_NAME:-400.7.20190306.0}"

This comment has been minimized.

@ashcrow

ashcrow Mar 12, 2019

Member

I don't have a problem with this but note that the version referenced isn't an official cut.

This comment has been minimized.

@wking

wking Mar 12, 2019

Author Member

I don't have a problem with this but note that the version referenced isn't an official cut.

I don't care what we pin to, just tell me what you want ;)

This comment has been minimized.

@ashcrow

ashcrow Mar 12, 2019

Member

This is fine. I just wanted to note that it wasn't an officially ID'd build for any specific cut.

This comment has been minimized.

@ashcrow

ashcrow Mar 13, 2019

Member

FWIW 400.7.20190312.0 now exists which includes a pivot update among other things. @cgwalters do you need that as part of the pin?

This comment has been minimized.

@cgwalters

cgwalters Mar 13, 2019

Contributor

My tentative vote here is to ship this as is now and start building "mental muscle memory" or SOP for bumping it immediately after, but it's not a really strong opinion.

@abhinavdahiya

This comment has been minimized.

Copy link
Member

abhinavdahiya commented Mar 13, 2019

/test e2e-aws-rhel8

@cgwalters

This comment has been minimized.

Copy link
Contributor

cgwalters commented Mar 13, 2019

:shipit: ?

@cgwalters cgwalters referenced this pull request Mar 13, 2019

Closed

rhcos: Support channels #1402

@cgwalters

This comment has been minimized.

Copy link
Contributor

cgwalters commented Mar 13, 2019

/lgtm

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Mar 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, cgwalters, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ashcrow

This comment has been minimized.

Copy link
Member

ashcrow commented Mar 13, 2019

resource quota and replica set errors. Flakes?

@cgwalters

This comment has been minimized.

Copy link
Contributor

cgwalters commented Mar 13, 2019

/retest

Yeah we have a successful run with the same commit.

@openshift-merge-robot openshift-merge-robot merged commit 37b99d8 into openshift:master Mar 13, 2019

12 checks passed

ci/prow/e2e-aws Job succeeded.
Details
ci/prow/e2e-aws-rhel8 Job succeeded.
Details
ci/prow/gofmt Job succeeded.
Details
ci/prow/golint Job succeeded.
Details
ci/prow/govet Job succeeded.
Details
ci/prow/images Job succeeded.
Details
ci/prow/shellcheck Job succeeded.
Details
ci/prow/tf-fmt Job succeeded.
Details
ci/prow/tf-lint Job succeeded.
Details
ci/prow/unit Job succeeded.
Details
ci/prow/yaml-lint Job succeeded.
Details
tide In merge pool.
Details

@wking wking deleted the wking:pin-rhcos branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.