Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data/gcp/dns: api.cluster_domain inside the VPC must point to internal LB for consistency #2000

Merged
merged 2 commits into from Jul 16, 2019
Merged

data/gcp/dns: api.cluster_domain inside the VPC must point to internal LB for consistency #2000

merged 2 commits into from Jul 16, 2019

Conversation

abhinavdahiya
Copy link
Contributor

similar to other platforms like AWS:

installer/data/data/aws/route53/base.tf

Line 53 in 37f7257

name = var.api_internal_lb_dns_name

/cc @csrwng @jstuever

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 16, 2019
@abhinavdahiya
Copy link
Contributor Author

/label platform/google

@csrwng
Copy link
Contributor

csrwng commented Jul 16, 2019

/lgtm
Thx for fixing it

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

@abhinavdahiya: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt 0c16e7b link /test e2e-libvirt
ci/prow/e2e-aws-scaleup-rhel7 0c16e7b link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 196f432 into openshift:master Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@jstuever jstuever Awaiting requested review from jstuever

Assignees

@csrwng csrwng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/google size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abhinavdahiya @csrwng @openshift-ci-robot @openshift-merge-robot