Bug 1746119: GCP Terraform ignore changes to min_cpu_platform #2325
Conversation
In GCP, terraform apply is run during bootstrap destroy to remove the bootstrap node from the LB. If control plane machine_type is set to the n2-standard series, master & bootstrap instances are created with min_cpu_platform = "Intel Cascade Lake," but the terraform configuration has min_cpu_platform = null. As terraform tries to switch min_cpu_platform back to null, installer will error with: level=error msg="Error: Changing the machine_type, min_cpu_platform, or service_account on an instance requires stopping it. To acknowledge this, please set allow_stopping_for_update = true in your config." By using lifecycle ignore_changes we can prevent TF from mistakenly trying to switch min_cpu_platform back to null.
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@patrickdillon: This pull request references Bugzilla bug 1746119, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/S
|
@patrickdillon: This pull request references Bugzilla bug 1746119, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Nice find! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@patrickdillon: All pull requests linked via external trackers have merged. Bugzilla bug 1746119 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@patrickdillon: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
In GCP, terraform apply is run during bootstrap destroy to remove the bootstrap node from the LB. If control plane machine_type is set to the n2-standard series, master & bootstrap instances are created with min_cpu_platform = "Intel Cascade Lake," but the terraform configuration has min_cpu_platform = null. As terraform tries to switch min_cpu_platform back to null, installer will error with:
By using lifecycle ignore_changes we can prevent TF from mistakenly trying to switch min_cpu_platform back to null.