WIP: Never disable hyperthreading and add tsx=on to kernel params #2806
Conversation
The more-convenient property got vendored in with 5366d28 (vendor: Bump machine-config-operator to latest, 2019-10-30, openshift#2594) as part of FIPS support.
|
@wking: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
FYI: unit/vet/etc... is expected to fail. |
Enable Transactional Synchronization Extensions [1]. These were disabled by default for CVE-2019-11135 [2,3], but we think the change is causing a perfomance impact. Re-enable it to see if we recover. While testing this, I'm stealing some scaffolding which was previously used for disabling hyperthreading. We want both TSX and hyperthreading for this test. If it turns out to be useful, we can work out if/how we want an install-config TSX knob to work. [1]: https://en.wikipedia.org/wiki/Transactional_Synchronization_Extensions [2]: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-11135 [3]: https://access.redhat.com/articles/tsx-asynchronousabort
As described in [1], because we want to test etcd stability when we have the fast, vulnerable throttle wide open. [1]: https://access.redhat.com/articles/tsx-asynchronousabort
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
RHCOS folks have a solid lead, no need for me to poke things anymore. /close |
|
@wking: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Enable Transactional Synchronization Extensions. These were disabled by default for CVE-2019-11135 (article), but we think the change is causing a perfomance impact. Re-enable it to see if we recover.
While testing this, I'm stealing some scaffolding which was previously used for disabling hyperthreading. We want both TSX and hyperthreading for this test. If it turns out to be useful, we can work out if/how we want an install-config TSX knob to work.