New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug 1815518: pkg/destroy/aws: delete versioned objects from s3 buckets #3393
bug 1815518: pkg/destroy/aws: delete versioned objects from s3 buckets #3393
Conversation
@jhixson74: This pull request references Bugzilla bug 1815518, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2c05022
to
ec29847
Compare
ec29847
to
0464bed
Compare
0464bed
to
4afa7c7
Compare
6100afb
to
67560b5
Compare
/approve this looks good, one last comment #3393 (comment) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
67560b5
to
3589ae6
Compare
/lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/hold |
Yup, found error,
|
This commit fixes the problem where S3 bucket deletion would fail if it had versioned objects. deleteS3() now does a mass delete of any versioned objects in the S3 bucket before deleting the bucket.
3589ae6
to
f29364c
Compare
/lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@jhixson74: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@jhixson74: All pull requests linked via external trackers have merged: openshift/installer#3393. Bugzilla bug 1815518 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This commit fixes the problem where S3 bucket deletion would fail if it had
versioned objects. deleteS3() now does a mass delete of any versioned objects
in the S3 bucket before deleting the bucket.