Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug 1815518: pkg/destroy/aws: delete versioned objects from s3 buckets #3393

Merged

Conversation

jhixson74
Copy link
Member

This commit fixes the problem where S3 bucket deletion would fail if it had
versioned objects. deleteS3() now does a mass delete of any versioned objects
in the S3 bucket before deleting the bucket.

@openshift-ci-robot
Copy link
Contributor

@jhixson74: This pull request references Bugzilla bug 1815518, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

bug 1815518: pkg/destroy/aws: delete versioned objects from s3 buckets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 2, 2020
@jhixson74 jhixson74 force-pushed the master_aws_bz_1815518 branch 2 times, most recently from 6100afb to 67560b5 Compare April 2, 2020 17:49
@abhinavdahiya
Copy link
Contributor

/approve

this looks good, one last comment #3393 (comment)

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2020
@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@abhinavdahiya
Copy link
Contributor

/hold
https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_installer/3393/pull-ci-openshift-installer-master-e2e-aws/10920
doesn't have deprovision step logs, I want to be sure this destroy actually completes..

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 3, 2020
@abhinavdahiya
Copy link
Contributor

Yup, found error,

time="2020-04-02T18:36:42-07:00" level=debug msg="delete object failed InvalidParameter: 1 validation error(s) found.\n- missing required field, DeleteObjectsInput.Delete.Objects.\n: InvalidParameter: 1 validation error(s) found.\n- missing required field, DeleteObjectsInput.Delete.Objects.\n" arn="arn:aws:s3:::adahiya-1-rkl5h-image-registry-ca-central-1-ifujoueipxlffvmlbb"

This commit fixes the problem where S3 bucket deletion would fail if it had
versioned objects. deleteS3() now does a mass delete of any versioned objects
in the S3 bucket before deleting the bucket.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2020
@abhinavdahiya
Copy link
Contributor

/lgtm
/hold cancel

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 3, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

@jhixson74: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovirt f29364c link /test e2e-ovirt
ci/prow/e2e-aws-scaleup-rhel7 f29364c link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-libvirt f29364c link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 8cf1fe8 into openshift:master Apr 3, 2020
@openshift-ci-robot
Copy link
Contributor

@jhixson74: All pull requests linked via external trackers have merged: openshift/installer#3393. Bugzilla bug 1815518 has been moved to the MODIFIED state.

In response to this:

bug 1815518: pkg/destroy/aws: delete versioned objects from s3 buckets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants