Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1841913: images: libvirt: add yq to libvirt CI image #3685

Merged

Conversation

Prashanth684
Copy link
Contributor

@Prashanth684 Prashanth684 commented May 29, 2020

For s390x/ppc64le we do some amount of yaml manipulation, for example: openshift/release#9362
and we plan to add a volume size which will have increased disk space for certain tests. yq will be especially useful and easier to use than sed for these manipulations.

For s390x/ppc64le we do some amount of yaml manipulation, for example: openshift/release#9362
and we plan to add a volume size which will have increased disk space for certain tests. yq will be especially useful
and easier to use than sed for these manipulations.
@Prashanth684
Copy link
Contributor Author

/cc @jaypoulz @mkumatag

@abhinavdahiya
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2020
@Prashanth684
Copy link
Contributor Author

/retitle Bug 1841913: images: libvirt: add yq to libvirt CI image

@openshift-ci-robot openshift-ci-robot changed the title images: libvirt: add yq to libvirt CI image Bug 1841913: images: libvirt: add yq to libvirt CI image May 29, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label May 29, 2020
@openshift-ci-robot
Copy link
Contributor

@Prashanth684: This pull request references Bugzilla bug 1841913, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1841913: images: libvirt: add yq to libvirt CI image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 29, 2020
@openshift-ci-robot
Copy link
Contributor

@Prashanth684: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt 5983e96 link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Prashanth684
Copy link
Contributor Author

/test e2e-libvirt

@jaypoulz
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2020
@openshift-merge-robot openshift-merge-robot merged commit c14781c into openshift:master May 29, 2020
@openshift-ci-robot
Copy link
Contributor

@Prashanth684: All pull requests linked via external trackers have merged: openshift/installer#3685. Bugzilla bug 1841913 has been moved to the MODIFIED state.

In response to this:

Bug 1841913: images: libvirt: add yq to libvirt CI image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Prashanth684
Copy link
Contributor Author

/cherry-pick release-4.4
/cherry-pick release-4.3

@openshift-cherrypick-robot

@Prashanth684: new pull request created: #3687

In response to this:

/cherry-pick release-4.4
/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Prashanth684
Copy link
Contributor Author

/cherry-pick release-4.3

@openshift-cherrypick-robot

@Prashanth684: new pull request created: #3699

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Prashanth684
Copy link
Contributor Author

/cherry-pick release-4.2

@openshift-cherrypick-robot

@Prashanth684: new pull request created: #3700

In response to this:

/cherry-pick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Prashanth684 Prashanth684 deleted the installer-image branch February 12, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants