Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove metal todo for install gather support #3866

Merged
merged 1 commit into from Jul 9, 2020

Conversation

cybertron
Copy link
Member

This was implemented in #3617

@cybertron
Copy link
Member Author

/cc @stbenjam

@stbenjam
Copy link
Member

stbenjam commented Jul 8, 2020

Oh thanks!

/lgtm
/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 8, 2020
@stbenjam
Copy link
Member

stbenjam commented Jul 8, 2020

/label platform/baremetal

@openshift-ci-robot openshift-ci-robot added the platform/baremetal IPI bare metal hosts platform label Jul 8, 2020
@stbenjam
Copy link
Member

stbenjam commented Jul 8, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2020
@stbenjam
Copy link
Member

stbenjam commented Jul 8, 2020

@cybertron Would you mind removing the entry below that one too? The provisioning network is configurable to use alternative subnets.

@cybertron
Copy link
Member Author

Sure, I can do that.

install gather was implemented in openshift#3617, and the provisioning net
is fully configurable now.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2020
@stbenjam
Copy link
Member

stbenjam commented Jul 9, 2020

/lgtm
/hold cancel

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 9, 2020
@openshift-merge-robot openshift-merge-robot merged commit be1a23e into openshift:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/baremetal IPI bare metal hosts platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants