Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1848885: check if 404 returned before ask users questions #3874

Merged
merged 1 commit into from Jul 17, 2020
Merged

Bug 1848885: check if 404 returned before ask users questions #3874

merged 1 commit into from Jul 17, 2020

Conversation

dougsland
Copy link
Contributor

Before ask users questions like: user/pass we should
validate that host AND PKI URL from engine are both
reachable.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1848885
Signed-off-by: Douglas Schilling Landgraf dougsland@redhat.com

Before ask users questions like: user/pass we should
validate that host AND PKI URL from engine are both
reachable.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1848885
Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 10, 2020
@openshift-ci-robot
Copy link
Contributor

@dougsland: This pull request references Bugzilla bug 1848885, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1848885: check if 404 returned before ask users questions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gekorob
Copy link
Contributor

gekorob commented Jul 10, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2020
@dougsland
Copy link
Contributor Author

/test e2e-ovirt

@gekorob
Copy link
Contributor

gekorob commented Jul 15, 2020

/retest

@gekorob
Copy link
Contributor

gekorob commented Jul 16, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gekorob

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 78e10d1 into openshift:master Jul 17, 2020
@openshift-ci-robot
Copy link
Contributor

@dougsland: All pull requests linked via external trackers have merged: openshift/installer#3874. Bugzilla bug 1848885 has been moved to the MODIFIED state.

In response to this:

Bug 1848885: check if 404 returned before ask users questions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants