New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1870082: Use index in MachineSet names for Openstack IPI #4070
Bug 1870082: Use index in MachineSet names for Openstack IPI #4070
Conversation
I have problems accessing my Bugzilla account hence created #4069 with details. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierreprinetti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@yussufsh: This pull request references Bugzilla bug 1870082, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Since the availability zone name ends up in the machine name, we need to ensure that it contains only alphanumeric characters, Also, we'll have to take that into account when validating the cluster name length.
I do not know, but the fact that Yussuf was able to create an AZ with name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the documentation az names can contain everything except ":". https://docs.openstack.org/nova/latest/admin/availability-zones.html
If so, we need to get rid of special characters too. I created a go playground with an example how I would do it: https://play.golang.org/p/XqlHfz6IsE5
/retest |
Frankly I am not sure what is the relevance of appending the AZ name to the machineset. If it is just a matter of uniqueness then I think we could use the index (idx) instead of AZ name. Also, if I am not wrong the filename would be in same format. Just a suggestion to save us a lot of thinking. |
If we operate transformations to the AZ name (and if we want to keep composing the MachineSet name out of the AZ name), we might need to add random characters to the MachineSet name to prevent collisions. |
I wonder if this is not a problem with other cloud providers supporting AZ. |
It appears that AWS and GCP have URL-compatible zone names, and they compose the MachineSet name out of those. Sensible variability in AZ names is probably a problem of on-premise clouds.
|
@yussufsh Do you want to amend the PR and implement your idea? |
Sure about that. |
4d8dcc7
to
3650c75
Compare
Fixes openshift#4069 Signed-off-by: Yussuf Shaikh <yussuf@us.ibm.com>
3650c75
to
ec4dfc7
Compare
/test e2e-openstack |
/retest |
/test e2e-openstack |
/retest |
1 similar comment
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
8 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
16 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@yussufsh: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@yussufsh: All pull requests linked via external trackers have merged: Bugzilla bug 1870082 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #4069
Signed-off-by: Yussuf Shaikh yussuf@us.ibm.com