New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1871653: baremetal: set root device hints on host resources #4088
Bug 1871653: baremetal: set root device hints on host resources #4088
Conversation
@dhellmann: This pull request references Bugzilla bug 1871653, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
/hold cancel |
Nit, I'd mention 'baremetal' in the commit title, but otherwise lgtm |
Pass the root device hints given by the user in the install-config to the BareMetalHost resources created in the cluster. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
6d818ed
to
b2ef77e
Compare
I updated the commit and PR title. |
/label platform/baremetal |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
The only jobs that are failing are for unrelated platforms. /retest |
/retest |
1 similar comment
/retest |
/bugzilla refresh |
@dhellmann: This pull request references Bugzilla bug 1871653, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@dhellmann: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
@dhellmann: All pull requests linked via external trackers have merged: Bugzilla bug 1871653 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pass the root device hints given by the user in the install-config to
the BareMetalHost resources created in the cluster.