New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1856928: Fix Non yaml files in manifests/ or openshift/ directories preventing bootstrap from completing #4091
Bug 1856928: Fix Non yaml files in manifests/ or openshift/ directories preventing bootstrap from completing #4091
Conversation
/assign @abhinavdahiya |
/assign @crawford |
/test e2e-azure |
c201d26
to
1e32477
Compare
/test e2e-azure |
pkg/asset/manifests/openshift.go
Outdated
@@ -246,7 +246,12 @@ func (o *Openshift) Files() []*asset.File { | |||
|
|||
// Load returns the openshift asset from disk. | |||
func (o *Openshift) Load(f asset.FileFetcher) (bool, error) { | |||
fileList, err := f.FetchByPattern(filepath.Join(openshiftManifestDir, "*")) | |||
yamlFileList, err := f.FetchByPattern(filepath.Join(manifestDir, "*.yaml")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to check for errors here.
1e32477
to
69c9c76
Compare
69c9c76
to
8ffb989
Compare
…ests and openshift directory to avoid unwanted file types Since all the files from manifests/ and openshift/ directories are candidate for k8s resources to be pushed by the installer to the cluster when bootstrapping, having non yaml/json files causes failure on reading.
8ffb989
to
a1ce066
Compare
@SujanaN08: This pull request references Bugzilla bug 1856928, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
@SujanaN08: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@SujanaN08: All pull requests linked via external trackers have merged: Bugzilla bug 1856928 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fetching only yaml, yml, and json file types from manifests and openshift directory to avoid unwanted file types