Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vSphere Destroy: add log messages for tag destruction #4407

Conversation

patrickdillon
Copy link
Contributor

Prints Info message when tag and tag categories are successfully destroyed.

/test e2e-vsphere

pkg/destroy/vsphere/vsphere.go Outdated Show resolved Hide resolved
@@ -217,12 +217,14 @@ func (o *ClusterUninstaller) Run() error {
o.Logger.Errorln(err)
return err
}
o.Logger.WithField("Tag", o.InfraID).Info("Destroyed")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, if we are going to add the field to the "Destroyed" log event, we should add it to the other log events for the action. Specifically, use the logger returned by the call to WithField for the "Delete tag" log event and the error log event as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I think the new changes are in line with this suggestion.

Prints Info message when tag and tag categories are successfully destroyed.
@patrickdillon
Copy link
Contributor Author

/test e2e-vsphere

Copy link
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 4, 2020

@patrickdillon: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-workers-rhel7 cb46fbf link /test e2e-aws-workers-rhel7
ci/prow/e2e-vsphere cb46fbf link /test e2e-vsphere
ci/prow/e2e-ovirt cb46fbf link /test e2e-ovirt
ci/prow/e2e-libvirt cb46fbf link /test e2e-libvirt
ci/prow/e2e-crc cb46fbf link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 268a56a into openshift:master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants