New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1909587: openstack: Create Control plane nodes sequentially #4522
Conversation
@pierreprinetti: This pull request references Bugzilla bug 1909587, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
01b4e14
to
12a6cf9
Compare
@pierreprinetti: This pull request references Bugzilla bug 1909587, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
e3259f5
to
b9ae3f5
Compare
This patch addresses the OpenStack issue where the Compute module won't honour the soft-anti-affinity policy when servers are created concurrently.
b9ae3f5
to
b6e3088
Compare
/cc mbooth mandre |
@pierreprinetti: GitHub didn't allow me to request PR reviews from the following users: mbooth. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc mdbooth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
# be created sequentially rather than concurrently by Terraform. | ||
# | ||
# The reason why they need to be created one at a time is that OpenStack's | ||
# Compute module is currently unable to honour the "soft-anti-affinity" policy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HRH QEII thanks you for spelling honour
correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HM please
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
@pierreprinetti: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@pierreprinetti: All pull requests linked via external trackers have merged: Bugzilla bug 1909587 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
At first glance this looks OK because we require a minimum of 3 control plane nodes. However we need to confirm that machine API is able to pick the remaining machines and provision the additional nodes in case we set a replica count > 3. |
@mandre
The cluster correctly comes up with 5 Control plane nodes when @staebler We are hardcoding 3 masters in Terraform, to work around a long-standing bad behaviour of OpenStack's Compute module. I believe it would be good to have a couple eyeballs from the Installer team on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is acceptable in the short term where there is a strict requirement for 3 master nodes. That requirement will be relaxed in a future release (maybe 4.9, 4.10). We need to come up with a better solution at some point.
# minimum number of required Control plane nodes, as stated in the | ||
# documentation[1]. | ||
# | ||
# The expectation is that machine-api-operator will take care of creating any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The machine-api-operator is not involved in creating control plane nodes. Adding or removing control plane nodes after installation requires manual intervention by the user. However, there are plans to change this in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cherry-pick release-4.6 |
@pierreprinetti: new pull request created: #4550 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This patch addresses the OpenStack issue where the Compute module won't
honour the soft-anti-affinity policy when servers are created
concurrently.