Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1949923: apply defaults for root volume AZs if they aren't set #4860

Merged
merged 1 commit into from May 3, 2021

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Apr 20, 2021

This commit applies default values for root volume AZs before validating control plane and compute machine pools.

@openshift-ci-robot
Copy link
Contributor

@Fedosin: This pull request references Bugzilla bug 1949923, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (juriarte@redhat.com), skipping review request.

In response to this:

Bug 1949923: validate root volume AZs only if they are set

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 20, 2021
@Fedosin
Copy link
Contributor Author

Fedosin commented Apr 20, 2021

/retest

@@ -46,7 +46,7 @@ func ValidateMachinePool(p *openstack.MachinePool, ci *CloudInfo, controlPlane b
}

allErrs = append(allErrs, validateZones(p.RootVolume.Zones, ci.VolumeZones, fldPath.Child("rootVolume").Child("zones"))...)
if len(p.RootVolume.Zones) != 1 && len(p.RootVolume.Zones) != len(p.Zones) {
if len(p.RootVolume.Zones) > 1 && len(p.RootVolume.Zones) != len(p.Zones) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just trying to work out the expected semantics of p.RootVolume.Zones here. Below in validateZones we have:

func validateZones(input []string, available []string, fldPath *field.Path) field.ErrorList {
        // check if machinepool default
        if len(input) == 1 && input[0] == "" {
                return field.ErrorList{}
        }
...

which suggests that 'empty' RootVolume.Zones actually contains a single value of ""? I'll be honest: I don't fully understand the context here, but that seems like a potential source of error.

This commit applies default values for root volume azs before validating
control plane and compute machine pools.
@openshift-ci-robot
Copy link
Contributor

@Fedosin: This pull request references Bugzilla bug 1949923, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (rlobillo@redhat.com), skipping review request.

In response to this:

Bug 1949923: validate root volume AZs only if they are set

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Fedosin Fedosin changed the title Bug 1949923: validate root volume AZs only if they are set Bug 1949923: apply defaults for root volume AZs if they aren't set Apr 26, 2021
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2021

@Fedosin: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-crc e753f7f link /test e2e-crc
ci/prow/e2e-libvirt e753f7f link /test e2e-libvirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b330ac1 into openshift:master May 3, 2021
@openshift-ci-robot
Copy link
Contributor

@Fedosin: All pull requests linked via external trackers have merged:

Bugzilla bug 1949923 has been moved to the MODIFIED state.

In response to this:

Bug 1949923: apply defaults for root volume AZs if they aren't set

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants