New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
baremetal: make provisioningNetworkInterface optional #5015
baremetal: make provisioningNetworkInterface optional #5015
Conversation
/retest |
/hold cancel |
/retest |
/hold |
/hold cancel |
/retest |
1 similar comment
/retest |
/uncc dhellmann |
@@ -50,7 +50,7 @@ accessible over the external network which may not be desirable. | |||
|
|||
* **NIC #2 - Provisioning Network (optional) ** | |||
* A private network used for PXE based provisioning. | |||
* You must specify `provisioningNetworkInterface` to indicate which | |||
* You can specify `provisioningNetworkInterface` to indicate which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention that if not specified the interface is derived from the bootMACAddress
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also mention that when provisioningNetwrokInterface is specified, the user needs to make sure all the control plane hosts have an interface of that name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, updated. Apologies for the slow response.
This also depends on openshift/cluster-baremetal-operator#149 |
/retest |
Ugh, the manifests file isn't covered by baremetal-approvers OWNERS, but /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test e2e-metal-ipi-ovn-ipv6 |
1 similar comment
/test e2e-metal-ipi-ovn-ipv6 |
/label platform/baremetal Would you mind changing metal3 to baremetal in the commit and PR title? Metal3 doesn't mean much to the installer folks. |
|
/retest |
@asalkeld: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/approve Also, please include more informative commit messages according to the contributing guidelines. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hardys, patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
This was removed in openshift#5015 but we should still include it if a user provides a value - since it's now optional we'll pass an empty string if no value is provided, which will trigger the new logic that detects the interface name by MAC.
@patrickdillon @sadasu @stbenjam FYI this caused a regression ref https://bugzilla.redhat.com/show_bug.cgi?id=1984576 Looking at the test history, I can see that pull-ci-openshift-installer-master-e2e-metal-ipi-ovn-ipv6 never passed, we need to be careful to ensure that passes before merging any baremetal IPI PRs |
#5100 should resolve the regression I think. |
Yea sorry I missed this. I think the installer team normally relies on the platform teams to /lgtm before merging and take that as our word we think the change is good. |
This was removed in openshift#5015 but we should still include it if a user provides a value - since it's now optional we'll pass an empty string if no value is provided, which will trigger the new logic that detects the interface name by MAC.
This was removed in openshift#5015 but we should still include it if a user provides a value - since it's now optional we'll pass an empty string if no value is provided, which will trigger the new logic that detects the interface name by MAC.
No description provided.