New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
baremetal: Specify entrypoint when starting inspector #5208
baremetal: Specify entrypoint when starting inspector #5208
Conversation
data/data/bootstrap/baremetal/files/usr/local/bin/startironic.sh.template
Show resolved
Hide resolved
/label platform/baremetal |
302aa9e
to
240d40c
Compare
Since openshift/ironic-image#190 the inspector components and entrypoint moved to the ironic-image, so we need to update the image and entrypoint to match, also aligning with openshift/cluster-baremetal-operator#132
240d40c
to
5309d88
Compare
/approve |
@derekhiggins: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hardys, kirankt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Since openshift/ironic-image#190 the inspector components and entrypoint moved to the ironic-image, so we need to update the image and entrypoint to match, also aligning with openshift/cluster-baremetal-operator#132