Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baremetal: Specify entrypoint when starting inspector #5208

Merged

Conversation

derekhiggins
Copy link
Contributor

@derekhiggins derekhiggins commented Sep 13, 2021

Since openshift/ironic-image#190 the inspector components and entrypoint moved to the ironic-image, so we need to update the image and entrypoint to match, also aligning with openshift/cluster-baremetal-operator#132

@hardys
Copy link
Contributor

hardys commented Sep 13, 2021

/label platform/baremetal

@openshift-ci openshift-ci bot added the platform/baremetal IPI bare metal hosts platform label Sep 13, 2021
@hardys hardys requested review from hardys and removed request for markmc and celebdor September 13, 2021 13:55
Since openshift/ironic-image#190 the inspector components
and entrypoint moved to the ironic-image, so we need to
update the image and entrypoint to match, also aligning
with openshift/cluster-baremetal-operator#132
@hardys
Copy link
Contributor

hardys commented Sep 13, 2021

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2021

@derekhiggins: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-workers-rhel8 5309d88 link false /test e2e-aws-workers-rhel8
ci/prow/e2e-aws-single-node 5309d88 link false /test e2e-aws-single-node
ci/prow/e2e-metal-ipi 5309d88 link false /test e2e-metal-ipi
ci/prow/e2e-metal-ipi-virtualmedia 5309d88 link false /test e2e-metal-ipi-virtualmedia

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@kirankt kirankt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hardys, kirankt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7c706a0 into openshift:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/baremetal IPI bare metal hosts platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants