Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2012233: IBMCloud: Handle 5 rule SG limit #5289

Merged
merged 1 commit into from Oct 13, 2021

Conversation

cjschaef
Copy link
Member

IBM Cloud has a 5 (remote) rule limit on each SecurityGroup. A
recent change placed the rules over that limit on the ControlPlane
SG. Split rules on that SG into 2 SG for the ControlPlane traffic.

IBM Cloud has a 5 (remote) rule limit on each SecurityGroup. A
recent change placed the rules over that limit on the ControlPlane
SG. Split rules on that SG into 2 SG for the ControlPlane traffic.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. labels Oct 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2021

@cjschaef: This pull request references Bugzilla bug 2012233, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2012233: IBMCloud: Handle 5 rule SG limit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 11, 2021
@staebler
Copy link
Contributor

/bugzilla refresh
/approve

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2021

@staebler: This pull request references Bugzilla bug 2012233, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @pamoedom

In response to this:

/bugzilla refresh
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 12, 2021
@openshift-ci openshift-ci bot requested a review from pamoedom October 12, 2021 00:49
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2021
@cjschaef cjschaef marked this pull request as ready for review October 12, 2021 14:01
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2021

@cjschaef: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-workers-rhel7 7336cda link false /test e2e-aws-workers-rhel7
ci/prow/e2e-aws-workers-rhel8 7336cda link false /test e2e-aws-workers-rhel8
ci/prow/e2e-crc 7336cda link false /test e2e-crc
ci/prow/e2e-metal-ipi-ovn-ipv6 7336cda link false /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@pamoedom pamoedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2021
@pamoedom
Copy link
Contributor

/label qe-approved

With these changes, Terraform successfully progresses and all resources are now in place for bootstrapping, example:

DEBUG Apply complete! Resources: 60 added, 0 changed, 0 destroyed. 
DEBUG                                              
DEBUG Outputs:                                     
DEBUG                                              
DEBUG control_plane_security_group_id_list = [     
DEBUG   "r010-d49d3118-f20d-4c5f-9d4a-d3cb12aa0076", 
DEBUG   "r010-62d734b2-3118-40a9-bdf0-6b59e7317a44", 
DEBUG   "r010-5baee311-4c8f-4e8e-8aa8-fa7b9d35b81c", 
DEBUG   "r010-ad72a852-1de7-4f45-a6c9-8de8f42ca027", 
DEBUG ]                                            
DEBUG control_plane_subnet_id_list = [             
DEBUG   "02b7-7151c27e-28e6-4983-ad0a-6ab69ef908a2", 
DEBUG   "02c7-5d1a9080-f390-4b18-a85f-64fb93998db7", 
DEBUG   "02d7-f9c4dce0-e1cf-461c-a8a2-8cfb154400a3", 
DEBUG ]                                            
DEBUG control_plane_subnet_zone_list = [           
DEBUG   "eu-de-1",                                 
DEBUG   "eu-de-2",                                 
DEBUG   "eu-de-3",                                 
DEBUG ]

Regards.

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 13, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 527c461 into openshift:master Oct 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2021

@cjschaef: All pull requests linked via external trackers have merged:

Bugzilla bug 2012233 has been moved to the MODIFIED state.

In response to this:

Bug 2012233: IBMCloud: Handle 5 rule SG limit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cjschaef cjschaef deleted the bz_2012233 branch October 13, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants