Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2016008: aws: add newly supported regions for arm64 #5377

Merged
merged 2 commits into from Nov 13, 2021

Conversation

AnnaZivkovic
Copy link

This PR enables 3 regions for arm64:
eu-north-1
eu-west-3
me-south-1

m6g instances are now available in these regions:
https://aws.amazon.com/about-aws/whats-new/2021/02/aws-graviton2-based-m6g-c6g-r6g-instances-available-additional-regions/

The boot images for all architectures have been bumped to accommodate this change

@Prashanth684
Copy link
Contributor

/cc @miabbott

@openshift-ci openshift-ci bot requested a review from miabbott November 11, 2021 23:47
@Prashanth684
Copy link
Contributor

/retest-required

@miabbott
Copy link
Member

It looks like this is also including PowerVS regions; is that intended?

Could you amend the commit message to include the bootimage bump BZ for 4.10 - https://bugzilla.redhat.com/show_bug.cgi?id=2016008

Also, please note in the commit message the dependent BZs on the bootimage bump which are fixed/delivered via this change.

For example - #5280

The changes to the metadata look sane, but I would like to have a good paper trail via the commit messages.

Changes generated with:
```
plume cosa2stream --target data/data/coreos/rhcos.json --distro rhcos  x86_64=410.84.202111111322-0 s390x=410.84.202111111403-0 ppc64le=410.84.202111111404-0 aarch64=410.84.202111111403-0 --url https://rhcos-redirector.apps.art.xq1c.p1.openshiftapps.com/art/storage/releases --no-signatures
```
change includes fixes in the boot media for the following BZs:

2016004: [RFE] RHCOS: help determining whether a user-provided image was already booted (Ignition provisioning already performed)
2005507: SNO spoke cluster failing to reach coreos.live.rootfs_url is missing url in console

This change also includes metadata for powervs ova images which are now uploaded to IBMCloud as part of the RHCOS pipeline
ref: https://issues.redhat.com/browse/MULTIARCH-1617
@jstuever
Copy link
Contributor

/uncc
/cc @jlebon

@openshift-ci openshift-ci bot requested review from jlebon and removed request for jstuever November 12, 2021 18:36
m6g instances have been added to a few regions where it previously was not available [1]. AMIs are pushed to those regions, so update the list here

[1] https://aws.amazon.com/about-aws/whats-new/2021/02/aws-graviton2-based-m6g-c6g-r6g-instances-available-additional-regions/
@Prashanth684 Prashanth684 changed the title aws: add newly supported regions for arm64 Bug 2016008: aws: add newly supported regions for arm64 Nov 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2021

@AnnaZivkovic: An error was encountered querying GitHub for users with public email (mnguyen@redhat.com) for bug 2016008 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 2016008: aws: add newly supported regions for arm64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Prashanth684
Copy link
Contributor

It looks like this is also including PowerVS regions; is that intended?

Could you amend the commit message to include the bootimage bump BZ for 4.10 - https://bugzilla.redhat.com/show_bug.cgi?id=2016008

Also, please note in the commit message the dependent BZs on the bootimage bump which are fixed/delivered via this change.

For example - #5280

The changes to the metadata look sane, but I would like to have a good paper trail via the commit messages.

tagged Bug 2016008 for the bootimage bump and listed the associated dependent BZs. The coreos-assembler now has support for parsing IBMCloud and PowerVS metadata (coreos/coreos-assembler#2535) and since we have PowerVS ova images being uploaded to IBMCloud, it gets included when we run the cosa2stream command, so it is intended. In any case nothing is being done with it for now until the support for the platform itself gets in.

@miabbott
Copy link
Member

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Nov 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2021

@miabbott: This pull request references Bugzilla bug 2016008, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 12, 2021
Copy link
Member

@miabbott miabbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2021

@AnnaZivkovic: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws d90fe66 link false /test okd-e2e-aws
ci/prow/e2e-aws-workers-rhel8 d90fe66 link false /test e2e-aws-workers-rhel8
ci/prow/e2e-openstack d90fe66 link false /test e2e-openstack
ci/prow/e2e-aws-workers-rhel7 d90fe66 link false /test e2e-aws-workers-rhel7
ci/prow/e2e-crc d90fe66 link false /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@staebler
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: miabbott, staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2021
@staebler
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2021
@openshift-merge-robot openshift-merge-robot merged commit 8fc863d into openshift:master Nov 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 13, 2021

@AnnaZivkovic: All pull requests linked via external trackers have merged:

Bugzilla bug 2016008 has been moved to the MODIFIED state.

In response to this:

Bug 2016008: aws: add newly supported regions for arm64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants