New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
close a verify-codegen ci failure loophole #5447
Conversation
The codegen tests fail now as they should:
We should merge #5406 first |
fyi @patrickdillon |
/lgtm |
looks good to me |
hack/verify-codegen.sh
Outdated
@@ -3,7 +3,15 @@ | |||
if [ "$IS_CONTAINER" != "" ]; then | |||
set -x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just remove the set -x
and set +x
instead of going through the machinations of checking the return codes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i added e
instead
hack/verify-codegen.sh
Outdated
rc=$? | ||
if [ $rc != 0 ]; then | ||
exit 1 | ||
fi | ||
go generate ./pkg/rhcos/ami.go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to fail because the file no longer exists. We need a replacement for this. But we can comment it out for now.
1786131
to
6f6b93a
Compare
@staebler @jhixson74 PTAL at the updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good.
Please improve upon the PR and commit title so that they are not quite so generic.
/approve |
i updated the summary comment and pr title. hopefully gh picks those up. |
You need to push up the commit with the updated message. |
@staebler done |
git diff --exit-code | ||
set +ex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave this up above the git diff
as it was.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops. yup.
if the go codegen commands failed, the the hack/verify-codegen.sh script continued and the CI check passed. see openshift#5406 for an example. the script was not set to fail on a non-zero return code. this pr adds the bash e option to the set builtin to catch errors and exit on failure. Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
# See https://github.com/openshift/installer/pull/5447#discussion_r762340594 | ||
# go generate ./pkg/rhcos/ami.go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed with #5466.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds like i should just delete those two commented-out lines now then @staebler?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, leave them commented out. This PR will likely merge before mine.
/retest-required Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@clnperez: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
15 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
if the
go codegen
commands failed, the thehack/verify-codegen.sh
script continued and the CI check passed. see #5406 for an example. the script was not set to fail on a non-zero return code. this pr adds the bashe
option to theset
builtin to catch errors and exit on failure.Signed-off-by: Christy Norman christy@linux.vnet.ibm.com