Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2027501: bump RHCOS 4.10 bootimage metadata #5452

Merged

Conversation

saqibali-2k
Copy link
Contributor

@saqibali-2k saqibali-2k commented Dec 6, 2021

These changes will update the RHCOS 4.10 bootimage metadata in the installer.
This change includes fixes for the following BZs:

Bug 1990506 - Missing udev rules in initramfs for /dev/disk/by-id/scsi-* symlinks

This change will also introduce artifacts for for Aliyun, AWS GovCloud regions, and Nutanix.

Changes generated with:

$ cosa shell
[coreos-assembler]$ plume cosa2stream --target data/data/coreos/rhcos.json --distro rhcos --no-signatures \
--url https://rhcos-redirector.apps.art.xq1c.p1.openshiftapps.com/art/storage/releases aarch64=410.84.202112060851-0 \
ppc64le=410.84.202112041603-0 s390x=410.84.202112040202-0  x86_64=410.84.202112040202-0

Verification Steps:

  1. Install a new 4.10 cluster
  2. oc debug node/<node name> -- chroot /host rpm-ostree status
  3. Verify that the deployment version matches the version from this PR
    that matches the architecture you are testing on. (i.e. aarch64
    should have version 410.84.202112060851-0)

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 6, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 6, 2021

@saqibali-2k: This pull request references Bugzilla bug 1990506, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @HuijingHei

In response to this:

Bug 1990506: bump RHCOS 4.10 bootimage metadata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saqibali-2k saqibali-2k changed the title Bug 1990506: bump RHCOS 4.10 bootimage metadata Bug 2027501: bump RHCOS 4.10 bootimage metadata Dec 6, 2021
@saqibali-2k
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. and removed bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. labels Dec 6, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 6, 2021

@saqibali-2k: This pull request references Bugzilla bug 2027501, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 6, 2021

@saqibali-2k: An error was encountered querying GitHub for users with public email (mnguyen@redhat.com) for bug 2027501 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 2027501: bump RHCOS 4.10 bootimage metadata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saqibali-2k
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 6, 2021

@saqibali-2k: This pull request references Bugzilla bug 2027501, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saqibali-2k
Copy link
Contributor Author

/retest

@miabbott
Copy link
Member

miabbott commented Dec 6, 2021

@saqibali-2k could you update the commit message/description to indicate this also brings in metadata for Aliyun, AWS GovCloud regions, and Nutanix?

"sha256": "b355cb94d0e5e640f729419eea34f0a5fbd2dcb181bb00b229fcef2892bef660",
"uncompressed-sha256": "cd33b106831eec1dbb2914bec9df6b84b5e821ef639a35195e2681512530ddca"
"location": "https://rhcos-redirector.apps.art.xq1c.p1.openshiftapps.com/art/storage/releases/rhcos-4.10-aarch64/410.84.202112060851-0/aarch64/rhcos-410.84.202112060851-0-aws.aarch64.vmdk.gz",
"signature": "https://rhcos-redirector.apps.art.xq1c.p1.openshiftapps.com/art/storage/releases/rhcos-4.10-aarch64/410.84.202112060851-0/aarch64/rhcos-410.84.202112060851-0-aws.aarch64.vmdk.gz.sig",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new field for all the artifacts that we have not used in RHCOS before. If one were to follow this link, it would return an error.

This looks like it could be fallout related to coreos/stream-metadata-go#33

cc: @bgilbert

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, we have to pass --no-signatures; see #5268

@saqibali-2k looks like you need to rerun the plume command

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 6, 2021

@saqibali-2k: This pull request references Bugzilla bug 2027501, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

Bug 2027501: bump RHCOS 4.10 bootimage metadata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

These changes will update the RHCOS 4.10 bootimage metadata in the installer.
This change includes fixes for the following BZs:

Bug 1990506 - Missing udev rules in initramfs for /dev/disk/by-id/scsi-* symlinks

This change will also introduce artifacts for for Aliyun, AWS GovCloud regions,
and Nutanix.

Changes generated with:
```
plume cosa2stream --target data/data/coreos/rhcos.json --distro rhcos --no-signatures \
--url https://rhcos-redirector.apps.art.xq1c.p1.openshiftapps.com/art/storage/releases aarch64=410.84.202112060851-0 \
ppc64le=410.84.202112041603-0 s390x=410.84.202112040202-0  x86_64=410.84.202112040202-0
```
Verification Steps:

1. Install a new 4.10 cluster
2. oc debug node/<node name> -- chroot /host rpm-ostree status
3. Verify that the deployment version matches the version from this PR
   that matches the architecture you are testing on. (i.e. aarch64
   should have version 410.84.202112060851-0)
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 6, 2021

@saqibali-2k: This pull request references Bugzilla bug 2027501, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

Bug 2027501: bump RHCOS 4.10 bootimage metadata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kwoodson
Copy link
Contributor

kwoodson commented Dec 6, 2021

@miabbott I was able to test this PR.

The image ID that was selected was m-0xi5sh1y90lsbo8ayl0a. This seems to be the correct one for the us-east-1 region:

            "us-east-1": {
              "release": "410.84.202112040202-0",
              "image": "m-0xi5sh1y90lsbo8ayl0a"
            },

For Alibaba this /lgtm

@saqibali-2k
Copy link
Contributor Author

/retest-required

1 similar comment
@saqibali-2k
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 7, 2021

@saqibali-2k: An error was encountered querying GitHub for users with public email (mnguyen@redhat.com) for bug 2027501 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 2027501: bump RHCOS 4.10 bootimage metadata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@miabbott
Copy link
Member

miabbott commented Dec 7, 2021

/test e2e-azure
/test e2e-gcp
/test e2e-vsphere
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-ipv6
/test e2e-metal-ipi-virtualmedia

@miabbott
Copy link
Member

miabbott commented Dec 7, 2021

/retest

@miabbott
Copy link
Member

miabbott commented Dec 7, 2021

Seeing what looks like transient errors on some of the jobs:

STEP 1: FROM image-registry.openshift-image-registry.svc:5000/ci-op-122i2vtq/pipeline@sha256:59d2c9d7c06b0c2cb91e337cb95c35a44b34f276102b3ecf5f931838324ff31c
error: build error: error creating build container: Error parsing image configuration: Error fetching blob: invalid status code from registry 500 (Internal Server Error)
INFO[2021-12-07T15:51:10Z] Ran for 3s                                   
ERRO[2021-12-07T15:51:10Z] Some steps failed:                           
ERRO[2021-12-07T15:51:10Z] 
  * could not run steps: step src failed: the build src failed with reason DockerBuildFailed: Dockerfile build strategy has failed. 

May have to spam the /retest command...

@miabbott
Copy link
Member

miabbott commented Dec 7, 2021

The registry problem seems to be related to the us-east-1 outage affecting AWS

8:49 AM PST We are experiencing elevated error rates for EC2 APIs in the US-EAST-1 region. We have identified root cause and we are actively working towards recovery.

@miabbott
Copy link
Member

miabbott commented Dec 8, 2021

/retest

@miabbott
Copy link
Member

miabbott commented Dec 8, 2021

e2e-crc failing with a gcloud failure:

ERROR: gcloud crashed (SystemError): ffi_prep_closure(): bad user_data (it seems that the version of the libffi library seen at runtime is different from the 'ffi.h' file seen at compile-time)

e2e-azure got the nodes/cluster up and running, later e2e tests failed

okd-e2e-aws-upgrade uses FCOS to boostrap + install, so this PR shouldn't have affected that flow

e2e-metal-ipi-virtualmedia got the nodes/cluster up and running, later e2e tests failed

e2e-metal-ipi-ovn-dualstack got the nodes/cluster up and running, later e2e tests failed

Let's try the e2e-crc test one more time for grins, but generally I think this is good to merge

/approve
/test e2e-crc

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: miabbott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2021
@kwoodson
Copy link
Contributor

kwoodson commented Dec 8, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 9, 2021

@saqibali-2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure ed50619 link false /test e2e-azure
ci/prow/okd-e2e-aws-upgrade ed50619 link false /test okd-e2e-aws-upgrade
ci/prow/e2e-metal-ipi-virtualmedia ed50619 link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-ovn-dualstack ed50619 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-crc ed50619 link false /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

15 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f8b090d into openshift:master Dec 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 9, 2021

@saqibali-2k: All pull requests linked via external trackers have merged:

Bugzilla bug 2027501 has been moved to the MODIFIED state.

In response to this:

Bug 2027501: bump RHCOS 4.10 bootimage metadata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants