Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alibaba: fix: rename the bootstrap output variable #5460

Conversation

bd233
Copy link
Contributor

@bd233 bd233 commented Dec 8, 2021

Rename the variable name of the output bootstrap node's IP to bootstrap_ip

Rename the variable name of the output bootstrap node's IP

Signed-off-by: sunhui <wb-sh373163@alibaba-inc.com>
Copy link
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 8, 2021

@bd233: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-upgrade 2a59df5 link false /test okd-e2e-aws-upgrade
ci/prow/okd-e2e-aws 2a59df5 link false /test okd-e2e-aws
ci/prow/e2e-aws-fips 2a59df5 link false /test e2e-aws-fips
ci/prow/e2e-ovirt 2a59df5 link false /test e2e-ovirt
ci/prow/e2e-aws-workers-rhel7 2a59df5 link false /test e2e-aws-workers-rhel7
ci/prow/e2e-libvirt 2a59df5 link false /test e2e-libvirt
ci/prow/e2e-aws-single-node 2a59df5 link false /test e2e-aws-single-node
ci/prow/e2e-metal-single-node-live-iso 2a59df5 link false /test e2e-metal-single-node-live-iso
ci/prow/e2e-openstack 2a59df5 link false /test e2e-openstack
ci/prow/e2e-openstack-kuryr 2a59df5 link false /test e2e-openstack-kuryr
ci/prow/e2e-metal-ipi-ovn-ipv6 2a59df5 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-workers-rhel8 2a59df5 link false /test e2e-aws-workers-rhel8
ci/prow/e2e-crc 2a59df5 link false /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c88df43 into openshift:master Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants