[release-4.10] Bug 2077904:Fix empty string usage in ValidateForProvisioning #5835

openshift-cherrypick-robot · 2022-04-22T14:34:00Z

This is an automated cherry-pick of #5801

/assign patrickdillon

The zoneName and zonePath were always empty variables. The variables were initialized outside of the if/else and then reinitialized using := in the if/else causing their values to go out of scope before the function call to validateZoneRecords. Fixes: 43224

openshift-ci · 2022-04-22T14:34:18Z

@openshift-cherrypick-robot: Bugzilla bug 2074659 has been cloned as Bugzilla bug 2077904. Retitling PR to link against new bug.
/retitle [release-4.10] Bug 2077904:Fix empty string usage in ValidateForProvisioning

In response to this:

[release-4.10] Bug 2074659:Fix empty string usage in ValidateForProvisioning

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-04-22T14:34:35Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2077904, which is invalid:

expected dependent Bugzilla bug 2074659 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.10] Bug 2077904:Fix empty string usage in ValidateForProvisioning

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-04-22T17:23:53Z

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azurestack-upi	`bebc2ac`	link	false	`/test e2e-azurestack-upi`
ci/prow/e2e-alibaba	`bebc2ac`	link	false	`/test e2e-alibaba`
ci/prow/e2e-aws-single-node	`bebc2ac`	link	false	`/test e2e-aws-single-node`
ci/prow/okd-e2e-vsphere	`bebc2ac`	link	false	`/test okd-e2e-vsphere`
ci/prow/e2e-aws-workers-rhel8	`bebc2ac`	link	false	`/test e2e-aws-workers-rhel8`
ci/prow/e2e-aws-fips	`bebc2ac`	link	false	`/test e2e-aws-fips`
ci/prow/e2e-azurestack	`bebc2ac`	link	false	`/test e2e-azurestack`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

barbacbd · 2022-04-26T16:15:53Z

/bugzilla refresh

openshift-ci · 2022-04-26T16:15:57Z

@barbacbd: This pull request references Bugzilla bug 2077904, which is invalid:

expected dependent Bugzilla bug 2074659 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

barbacbd · 2022-04-26T16:18:07Z

/bugzilla refresh

openshift-ci · 2022-04-26T16:18:10Z

@barbacbd: This pull request references Bugzilla bug 2077904, which is invalid:

expected dependent Bugzilla bug 2074659 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

patrickdillon · 2022-05-02T13:59:03Z

/lgtm
/approve
/label backport-risk-assessed

openshift-ci · 2022-05-02T13:59:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/asset/installconfig/aws/OWNERS~~ [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2022-05-02T14:10:29Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-02T16:07:29Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-02T17:12:26Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-02T17:36:28Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-02T18:00:31Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-02T22:26:17Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-02T23:14:14Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-03T00:15:13Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-03T01:00:27Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-05-03T01:00:45Z

@openshift-bot: This pull request references Bugzilla bug 2077904, which is invalid:

expected dependent Bugzilla bug 2074659 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-05-25T13:19:55Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-25T13:55:55Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-25T14:31:55Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-25T21:00:41Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-25T22:44:35Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-26T00:54:34Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-26T01:00:45Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-05-26T01:01:20Z

@openshift-bot: This pull request references Bugzilla bug 2077904, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.z) matches configured target release for branch (4.10.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2074659 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2074659 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (yunjiang@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-05-26T04:37:33Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-26T04:49:35Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-26T05:13:33Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-26T06:49:35Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-26T07:37:33Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-26T07:49:36Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-26T08:37:33Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-26T10:25:35Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-26T10:37:35Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-26T11:13:34Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-26T11:37:35Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-26T11:49:38Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-26T13:15:34Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-26T13:27:38Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-26T13:52:35Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-05-26T14:29:36Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

gpei · 2022-05-27T00:05:49Z

/label cherry-pick-approved

openshift-ci · 2022-05-27T01:59:42Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/installer#5835

Bugzilla bug 2077904 has been moved to the MODIFIED state.

In response to this:

[release-4.10] Bug 2077904:Fix empty string usage in ValidateForProvisioning

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot assigned patrickdillon Apr 22, 2022

openshift-cherrypick-robot mentioned this pull request Apr 22, 2022

Bug 2074659:Fix empty string usage in ValidateForProvisioning #5801

Merged

openshift-ci bot changed the title ~~[release-4.10] Bug 2074659:Fix empty string usage in ValidateForProvisioning~~ [release-4.10] Bug 2077904:Fix empty string usage in ValidateForProvisioning Apr 22, 2022

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 22, 2022

openshift-ci bot requested review from jstuever and patrickdillon April 22, 2022 14:34

openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. lgtm Indicates that a PR is ready to be merged. labels May 2, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2022

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 26, 2022

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 27, 2022

openshift-merge-robot merged commit 25f4975 into openshift:release-4.10 May 27, 2022

[release-4.10] Bug 2077904:Fix empty string usage in ValidateForProvisioning #5835

[release-4.10] Bug 2077904:Fix empty string usage in ValidateForProvisioning #5835

Conversation

openshift-cherrypick-robot commented Apr 22, 2022

openshift-ci bot commented Apr 22, 2022

openshift-ci bot commented Apr 22, 2022

openshift-ci bot commented Apr 22, 2022 • edited

barbacbd commented Apr 26, 2022

openshift-ci bot commented Apr 26, 2022

barbacbd commented Apr 26, 2022

openshift-ci bot commented Apr 26, 2022

patrickdillon commented May 2, 2022

openshift-ci bot commented May 2, 2022

openshift-bot commented May 2, 2022

openshift-bot commented May 2, 2022

openshift-bot commented May 2, 2022

openshift-bot commented May 2, 2022

openshift-bot commented May 2, 2022

openshift-bot commented May 2, 2022

openshift-bot commented May 2, 2022

openshift-bot commented May 3, 2022

openshift-bot commented May 3, 2022

openshift-ci bot commented May 3, 2022

openshift-bot commented May 25, 2022

openshift-bot commented May 25, 2022

openshift-bot commented May 25, 2022

openshift-bot commented May 25, 2022

openshift-bot commented May 25, 2022

openshift-bot commented May 26, 2022

openshift-bot commented May 26, 2022

openshift-ci bot commented May 26, 2022

openshift-bot commented May 26, 2022

openshift-bot commented May 26, 2022

openshift-bot commented May 26, 2022

openshift-bot commented May 26, 2022

openshift-bot commented May 26, 2022

openshift-bot commented May 26, 2022

openshift-bot commented May 26, 2022

openshift-bot commented May 26, 2022

openshift-bot commented May 26, 2022

openshift-bot commented May 26, 2022

openshift-bot commented May 26, 2022

openshift-bot commented May 26, 2022

openshift-bot commented May 26, 2022

openshift-bot commented May 26, 2022

openshift-bot commented May 26, 2022

openshift-bot commented May 26, 2022

gpei commented May 27, 2022

openshift-ci bot commented May 27, 2022

openshift-ci bot commented Apr 22, 2022 •

edited