[release-4.11] Bug 2104727: Fixes CFE-489 - AWS installer should go through proxy for s3 bootstrap ignition call #6090
Conversation
awstfvars contain the Proxy struct from installConfig. GenerateIgnitionShimWithCertBundleAndProxy replaces GenerateIgnitionShimWithCertBundle for AWS GenerateIgnitionShimWithCertBundleAndProxy func is created under pkg/ignition/bootstrap/bootstrap_ignition.go as it becomes common with the Openstack use. Another possibility is to keep it in pkg/tfvars/aws/bootstrap_ignition.go (no code sharing) Fixes CFE-489 BZ-2090836
…use function GenerateIgnitionShimWithCertBundle Instead of duplicating code between the 2 functions in pkg/asset/cluster/tfvars.go, a private generateIgnitionShimWithCertBundle is added, containing common code Fixes CFE-489 BZ-2090836
…erateIgnitionShimWithCertBundle` `GenerateIgnitionShimWithCertBundle` was used in Azure and Alibaba (other than in AWS) In order to prepare for supporting proxy for other platforms, as discussed in the PR comments, this change replaces this function by `GenerateIgnitionShimWithCertBundleAndProxy` Fixes CFE-489 BZ-2090836
|
@openshift-cherrypick-robot: Bugzilla bug 2090836 has been cloned as Bugzilla bug 2104727. Retitling PR to link against new bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
changed the title
openshift-ci
bot
added
bugzilla/severity-urgent
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 2104727, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (yunjiang@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-aws-proxy |
|
/test e2e-alibaba |
|
/test e2e-aws-proxy |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
sdodson
added
the
staff-eng-approved
|
Adding staff-eng-approved after codefreeze on this functional change as discussions with Engineering and Docs indicate that it's much better for us to make this change prior to GA than to deal with post-GA change management process. |
|
/refresh |
openshift-ci
bot
merged commit bd27fd8
into
openshift:release-4.11
|
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 2104727 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #5973
/assign sherine-k