Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.11] Bug 2105331: Switch to perform normal marshalling with unknown fields #6102

Merged
merged 1 commit into from Nov 11, 2022
Merged

[release-4.11] Bug 2105331: Switch to perform normal marshalling with unknown fields #6102

merged 1 commit into from Nov 11, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #6039

/assign patrickdillon

@rna-afk
installconfig: Move fatal error to warn for strict marshal
7a90f14 
The hive team uses a lot of fields in the install config that might
not exist due to older versions of the installer missing a few fields
that may have been added in the newer versions, which causes the
installer to reject them all but is needed for proper functioning.

Changing the code a little to now provide a warning message to the
user in case of any unknown fields and then try to unmarshal it
without the unknown fields check.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 8, 2022
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2022

@openshift-cherrypick-robot: Bugzilla bug 2098299 has been cloned as Bugzilla bug 2105331. Retitling PR to link against new bug.
/retitle [release-4.11] Bug 2105331: Switch to perform normal marshalling with unknown fields

In response to this:

[release-4.11] Bug 2098299: Switch to perform normal marshalling with unknown fields

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.11] Bug 2098299: Switch to perform normal marshalling with unknown fields [release-4.11] Bug 2105331: Switch to perform normal marshalling with unknown fields Jul 8, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2105331, which is invalid:

  • expected dependent Bugzilla bug 2098299 to target a release in 4.12.0, but it targets "4.11.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.11] Bug 2105331: Switch to perform normal marshalling with unknown fields

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jstuever and rna-afk July 8, 2022 15:00
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2022

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere 7a90f14 link false /test e2e-vsphere

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@r4f4
Copy link
Contributor

r4f4 commented Aug 19, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2022

@r4f4: This pull request references Bugzilla bug 2105331, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.z) matches configured target release for branch (4.11.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2098299 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2098299 targets the "4.12.0" release, which is one of the valid target releases: 4.12.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (yunjiang@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 19, 2022
@r4f4
Copy link
Contributor

r4f4 commented Aug 19, 2022

/retest-required

3 similar comments
@sadasu
Copy link
Contributor

sadasu commented Sep 22, 2022

/retest-required

@rna-afk
Copy link
Contributor

rna-afk commented Sep 23, 2022

/retest-required

@sadasu
Copy link
Contributor

sadasu commented Oct 11, 2022

/retest-required

@jstuever
Copy link
Contributor

/cc @patrickdillon
/uncc

@openshift-ci openshift-ci bot requested review from patrickdillon and removed request for jstuever October 12, 2022 16:06
@sadasu
Copy link
Contributor

sadasu commented Oct 13, 2022

/retest-required

@patrickdillon
Copy link
Contributor

/approve
/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. lgtm Indicates that a PR is ready to be merged. labels Oct 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2022
@sadasu
Copy link
Contributor

sadasu commented Oct 19, 2022

/label backport-risk-assessed

@sadasu
Copy link
Contributor

sadasu commented Oct 19, 2022

/retest-required

@gpei
Copy link
Contributor

gpei commented Nov 11, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 11, 2022
@openshift-merge-robot openshift-merge-robot merged commit 0c4e731 into openshift:release-4.11 Nov 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2105331 has been moved to the MODIFIED state.

In response to this:

[release-4.11] Bug 2105331: Switch to perform normal marshalling with unknown fields

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rna-afk rna-afk Awaiting requested review from rna-afk

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@patrickdillon patrickdillon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@openshift-cherrypick-robot @r4f4 @sadasu @rna-afk @jstuever @patrickdillon @gpei @openshift-merge-robot