New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGSM-47737: Do not enable pre-network-manager-config.service #6323
Conversation
Depends on #6317 |
7f05a43
to
61a9da9
Compare
The unit tests are failing because nmstatectl isn't available on some of the ci test environment. I will add a test skip to not run the Generate test if nmstatectl can't be found in the environment. We already have an existing test skip in TestIgnition_addStaticNetworkConfig for the same issue.
|
/retest-required |
/lgtm |
/lgtm |
@@ -123,6 +123,8 @@ func TestNMStateConfig_Generate(t *testing.T) { | |||
|
|||
if tc.expectedError != "" { | |||
assert.Equal(t, tc.expectedError, err.Error()) | |||
} else if tc.expectedConfig == nil { | |||
// no nmstateconfig expected | |||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I'd rephrase it as
else if tc.expectedConfig != nil {
assert.NoError(t, err)
...
when there are no nmstateconfigs defined. When DHCP is used, agent-config.yaml may have no networkConfigs defined, and therefore no nmstateconfigs will be generated. When nmstateconfigs are absent, the pre-network-manager-config systemd service should not be enabled.
The Generate function calls addStaticNetworkConfig which in turn calls nmstatectl. When nmstatectl isn't available in the test environment the test fails.
23aabb7
to
caa8323
Compare
/lgtm |
/test e2e-agent-compact |
/retest-required |
1 similar comment
/retest-required |
@rwsu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lranjbar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
when there are no nmstateconfigs defined.
When DHCP is used, agent-config.yaml may have no networkConfigs defined, and therefore no nmstateconfigs will be generated. When nmstateconfigs are absent, the pre-network-manager-config systemd service should not be enabled.