Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vsphere: prevent duplicate validation check in multi-zone #6398

Merged
merged 1 commit into from Sep 23, 2022
Merged

vsphere: prevent duplicate validation check in multi-zone #6398

merged 1 commit into from Sep 23, 2022

Conversation

bostrt
Copy link
Contributor

@bostrt bostrt commented Sep 22, 2022 •
edited

ValidateMultiZoneForProvisioning is calling ValidateForProvisioning here already so it can be skipped in platformprovisioncheck.go

@openshift-ci openshift-ci bot requested review from r4f4 and sadasu September 22, 2022 14:24
@bostrt
Copy link
Contributor Author

bostrt commented Sep 22, 2022

/cc @rvanderp3 @jcpowermac

@bostrt
Copy link
Contributor Author

bostrt commented Sep 22, 2022

/assign @AnnaZivkovic

r4f4
r4f4 reviewed Sep 22, 2022
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2022
@r4f4 r4f4 removed their assignment Sep 22, 2022
@sadasu
Copy link
Contributor

sadasu commented Sep 22, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2022

@bostrt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-gcp-ovn-upgrade 4db999f link false /test okd-e2e-gcp-ovn-upgrade
ci/prow/okd-e2e-aws-ovn 4db999f link false /test okd-e2e-aws-ovn
ci/prow/e2e-openstack 4db999f link false /test e2e-openstack
ci/prow/e2e-libvirt 4db999f link false /test e2e-libvirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sadasu
Copy link
Contributor

sadasu commented Sep 22, 2022

/skip

@openshift-merge-robot openshift-merge-robot merged commit c1f45ed into openshift:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r4f4 r4f4 r4f4 left review comments

@sadasu sadasu Awaiting requested review from sadasu

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@rvanderp3 rvanderp3 Awaiting requested review from rvanderp3

Assignees

@AnnaZivkovic AnnaZivkovic

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bostrt @sadasu @r4f4 @openshift-merge-robot @AnnaZivkovic