Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mv ibmcloud to /bin folder #6624

Merged
merged 1 commit into from Nov 25, 2022
Merged

mv ibmcloud to /bin folder #6624

merged 1 commit into from Nov 25, 2022

Conversation

MayXuQQ
Copy link
Contributor

@MayXuQQ MayXuQQ commented Nov 24, 2022 •
edited

  1. ibmcloud installed in /usr/local/bin, the env PATH just has /bin, need mv it.
  2. echo "-4" > ./.curlrc help resolving the download ibmcloud cli error

Error: Get "https://download.clis.cloud.ibm.com/ibm-cloud-cli-plugin/cloud-internet-services/1.14.9/cloud-internet-services-linux-amd64-1.14.9": dial tcp [2600:1408:c400:21::17d4:fb48]:443: connect: network is unreachable

3.HOME=/output before ibmcloud download to resolve the issue of no ibmcloud plugin in release test.

@MayXuQQ
Copy link
Contributor Author

MayXuQQ commented Nov 24, 2022

/assign @r4f4

@MayXuQQ
Copy link
Contributor Author

MayXuQQ commented Nov 24, 2022

/test e2e-agent-sno

@r4f4
Copy link
Contributor

r4f4 commented Nov 24, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2022
@r4f4
Copy link
Contributor

r4f4 commented Nov 24, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD f04db08 and 2 for PR HEAD 7d9eb06 in total

@MayXuQQ
Copy link
Contributor Author

MayXuQQ commented Nov 24, 2022

/test okd-e2e-aws-ovn
/test okd-scos-e2e-aws-upgrade

  • checked the ipi-install-install step pass in the following jobs:
    e2e-aws-ovn-disruptive e2e-gcp-ovn
  • the following jobs failed recently:
    e2e-libvirt

@MayXuQQ
Copy link
Contributor Author

MayXuQQ commented Nov 24, 2022

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2022
@MayXuQQ
Copy link
Contributor Author

MayXuQQ commented Nov 24, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2022
@MayXuQQ
Copy link
Contributor Author

MayXuQQ commented Nov 25, 2022

/retest-required

@MayXuQQ
Copy link
Contributor Author

MayXuQQ commented Nov 25, 2022

/test e2e-aws-ovn-upi

@MayXuQQ MayXuQQ force-pushed the ibmcloud_cli2 branch 2 times, most recently from c616fdf to 6e74a8a Compare November 25, 2022 08:41
jianlinliu
jianlinliu reviewed Nov 25, 2022
View reviewed changes
images/installer/Dockerfile.upi.ci Outdated
ibmcloud version && \
ibmcloud plugin list

RUN chown 1000:1000 /output
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be RUN chown -R 1000:1000 /output

jianlinliu
jianlinliu reviewed Nov 25, 2022
View reviewed changes
images/installer/Dockerfile.upi.ci Outdated
ibmcloud plugin install cloud-internet-services -f && \
cp /usr/local/bin/ibmcloud /bin/ibmcloud && \
chmod -R g=u "$HOME/.bluemix/" && \
rm -f ~/.curlrc && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls use rm -f ${HOME}/.curlrc to keep consistent

@MayXuQQ MayXuQQ force-pushed the ibmcloud_cli2 branch 2 times, most recently from 1a2911b to 1afa91c Compare November 25, 2022 10:05
@MayXuQQ
Copy link
Contributor Author

MayXuQQ commented Nov 25, 2022

checked the running jobs , all got "Tagging upi-installer into stable"

@jianlinliu
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD f04db08 and 2 for PR HEAD cb6ddea in total

@MayXuQQ
Copy link
Contributor Author

MayXuQQ commented Nov 25, 2022

@r4f4
Copy link
Contributor

r4f4 commented Nov 25, 2022

/override ci/prow/e2e-azure-ovn-upi
Install succeeded, only some e2e failures

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 25, 2022

@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-azure-ovn-upi

In response to this:

/override ci/prow/e2e-azure-ovn-upi
Install succeeded, only some e2e failures

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4
Copy link
Contributor

r4f4 commented Nov 25, 2022

/override ci/prow/e2e-vsphere-ovn
Known e2e failures

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 25, 2022

@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-vsphere-ovn

In response to this:

/override ci/prow/e2e-vsphere-ovn
Known e2e failures

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit a99da45 into openshift:master Nov 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 25, 2022

@MayXuQQ: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-disruptive cb6ddea link false /test e2e-aws-ovn-disruptive
ci/prow/e2e-libvirt cb6ddea link false /test e2e-libvirt
ci/prow/okd-scos-e2e-aws-upgrade cb6ddea link false /test okd-scos-e2e-aws-upgrade
ci/prow/e2e-openstack cb6ddea link false /test e2e-openstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MayXuQQ MayXuQQ deleted the ibmcloud_cli2 branch November 30, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianlinliu jianlinliu jianlinliu left review comments

@AnnaZivkovic AnnaZivkovic Awaiting requested review from AnnaZivkovic

@jhixson74 jhixson74 Awaiting requested review from jhixson74

Assignees

@r4f4 r4f4

@jianlinliu jianlinliu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MayXuQQ @r4f4 @openshift-ci-robot @jianlinliu @openshift-merge-robot