New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1888712: Support for including vlan interfaces in introspection r… #154
Conversation
…eport Add the inspector kernel param to include vlan interfaces and associated IP addresses in the introspection report. This feature was added to IPA in https://review.opendev.org/c/openstack/ironic-python-agent/+/760570. By default all VLAN interfaces are included in the report using LLDP info from the switch to determine the VLANs. An override is provided to define a particular VLAN interface if LLDP is not enabled.
|
@bfournie: This pull request references Bugzilla bug 1888712, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (nsharabi@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Can be merged whenever the CI is ready.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bfournie, dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/unhold |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
@bfournie: All pull requests linked via external trackers have merged: Bugzilla bug 1888712 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…ipleo Revert "Use tested packages"
…eport
Add the inspector kernel param to include vlan interfaces and
associated IP addresses in the introspection report. This feature
was added to IPA in
https://review.opendev.org/c/openstack/ironic-python-agent/+/760570.
By default all VLAN interfaces are included in the report using LLDP
info from the switch to determine the VLANs. An override is provided
to define a particular VLAN interface if LLDP is not enabled.