Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2012798: Ironic resumes clean before raid configuration job is actually completed #221

Merged
merged 1 commit into from Oct 25, 2021

Conversation

rhjanders
Copy link

This commit updates ironic-images so that these fixes:
https://review.opendev.org/c/openstack/ironic/+/812433
https://review.opendev.org/c/openstack/ironic/+/812434
are included.

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 11, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 11, 2021

@rhjanders: This pull request references Bugzilla bug 2012798, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2012798: Ironic resumes clean before raid configuration job is actually completed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhjanders
Copy link
Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2021
@rhjanders
Copy link
Author

(waiting for 4.9.z to open)

@rhjanders
Copy link
Author

/remove-hold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2021
@rhjanders
Copy link
Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 19, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2021

@rhjanders: This pull request references Bugzilla bug 2012798, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2011753 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2011753 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhjanders
Copy link
Author

/test ci/prow/prevalidation-images

@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2021

@rhjanders: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-virtualmedia
  • /test images
  • /test prevalidation-e2e-metal-ipi-prevalidation
  • /test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation
  • /test prevalidation-images

Use /test all to run all jobs.

In response to this:

/test ci/prow/prevalidation-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhjanders
Copy link
Author

/test prevalidation-e2e-metal-ipi-prevalidation

@rhjanders
Copy link
Author

/test ci/prow/prevalidation-images

@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2021

@rhjanders: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-virtualmedia
  • /test images
  • /test prevalidation-e2e-metal-ipi-prevalidation
  • /test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation
  • /test prevalidation-images

Use /test all to run all jobs.

In response to this:

/test ci/prow/prevalidation-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhjanders
Copy link
Author

/test prevalidation-images

@rhjanders
Copy link
Author

/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@rhjanders
Copy link
Author

/test prevalidation-e2e-metal-ipi-prevalidation

@rhjanders
Copy link
Author

/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@elfosardo
Copy link

/approved

@elfosardo
Copy link

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, rhjanders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2021
@elfosardo elfosardo added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 19, 2021
@rhjanders
Copy link
Author

/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@rhjanders
Copy link
Author

/test e2e-metal-ipi-virtualmedia

@rhjanders
Copy link
Author

/test e2e-metal-ipi

@rhjanders
Copy link
Author

/test images

@rhjanders
Copy link
Author

/test e2e-metal-ipi-virtualmedia

@bfournie
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2021
@hase1128
Copy link

@rhjanders

This PR needs cherry-pick-approved label to merge?

@rhjanders
Copy link
Author

@rhjanders

This PR needs cherry-pick-approved label to merge?

Correct - this needs to be done by one of our Patch Managers (outside of my team).

@mrunalp mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 25, 2021
@openshift-merge-robot openshift-merge-robot merged commit b122f11 into openshift:release-4.9 Oct 25, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2021

@rhjanders: All pull requests linked via external trackers have merged:

Bugzilla bug 2012798 has been moved to the MODIFIED state.

In response to this:

Bug 2012798: Ironic resumes clean before raid configuration job is actually completed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/ironic-image that referenced this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants