New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop unused ipxe.efi #260
Drop unused ipxe.efi #260
Conversation
openshift#76 seems to have removed the last use of ipxe.efi in favour of snponly.efi.
Skipping CI for Draft Pull Request. |
/test all |
/retest |
2 similar comments
/retest |
/retest |
/assign @elfosardo |
repo was out of sync |
/retest |
2 similar comments
/retest |
/retest |
@yselkowitz thanks! Two things:
|
Filed upstream metal3-io#365 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo, yselkowitz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
@yselkowitz CI will be fixed by #261 |
/retest |
1 similar comment
/retest |
@yselkowitz: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/cc @dtantsur |
@@ -13,12 +13,3 @@ mkdir -p /tftpboot | |||
|
|||
cp /usr/share/ipxe/undionly.kpxe /tftpboot/ | |||
cp /usr/share/ipxe/ipxe-snponly-x86_64.efi /tftpboot/snponly.efi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the future: I'm quite sure you want to do something about x86_64 here
/lgtm |
Fix the "permisison denied" bug properly
#76 seems to have removed the last use of ipxe.efi in favour of snponly.efi.
This will also help verify which ipxe artifacts are actually required for ARM BM IPI enablement (see https://bugzilla.redhat.com/show_bug.cgi?id=2059350).