Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-1740: Backport improvements to iDRAC steps to OCP 4.10 #303

Merged

Conversation

rhjanders
Copy link

@rhjanders rhjanders commented Oct 5, 2022

@openshift-ci
Copy link

openshift-ci bot commented Oct 5, 2022

@rhjanders: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-1740: Backport improvements to iDRAC steps to OCP 4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 5, 2022
@openshift-ci-robot
Copy link

@rhjanders: This pull request references Jira Issue OCPBUGS-1740, which is invalid:

  • expected dependent Jira Issue OCPBUGS-2011 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This commit backports upstream changes in OpenStack/Ironic which resolve https://issues.redhat.com/browse/OCPBUGS-1740 in OpenShift 4.10:

https://review.opendev.org/c/openstack/ironic/+/859918
https://review.opendev.org/c/openstack/ironic/+/860308

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from bfournie and zaneb October 5, 2022 02:33
@openshift-ci
Copy link

openshift-ci bot commented Oct 5, 2022

@rhjanders: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-1740: Backport improvements to iDRAC steps to OCP 4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@rhjanders: This pull request references Jira Issue OCPBUGS-1740, which is invalid:

  • expected dependent Jira Issue OCPBUGS-2011 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This commit backports upstream changes in OpenStack/Ironic which resolve https://issues.redhat.com/browse/OCPBUGS-1740 in OpenShift 4.10:

https://review.opendev.org/c/openstack/ironic/+/859918
https://review.opendev.org/c/openstack/ironic/+/860308

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhjanders
Copy link
Author

Once https://review.opendev.org/c/openstack/ironic/+/860308 merges and the package with this commit is built, will update versions once more and push.
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2022
@rhjanders
Copy link
Author

Updated versions to include the package with both fixes.
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2022
@rhjanders
Copy link
Author

Ran into an issue with getting the rpm built.
/hold again

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2022
@rhjanders
Copy link
Author

Package build now succeeded.
Tagged for pre-validation.
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2022
@rhjanders
Copy link
Author

/test prevalidation-images

@rhjanders
Copy link
Author

/retest

@rhjanders
Copy link
Author

hmm CI is not seeing the packages:

No match for argument: openstack-ironic-api >= 1:19.0.1-0.20221012164020.455c1a9.el8
No match for argument: openstack-ironic-conductor >= 1:19.0.1-0.20221012164020.455c1a9.el8
Error: Unable to find a match: openstack-ironic-api >= 1:19.0.1-0.20221012164020.455c1a9.el8 openstack-ironic-conductor >= 1:19.0.1-0.20221012164020.455c1a9.el8

that is despite the fact that to me they seem present:

https://mirror.openshift.com/enterprise/reposync/ci-ironic/rhaos-4.10-rhel-8-ironic-prevalidation/x86_64/os/Packages/openstack-ironic-19.0.1-0.20221012164020.455c1a9.el8__noarch/

I will re-try in few minutes (I may be too impatient) otherwise we may need to look into this further...

@rhjanders
Copy link
Author

/test prevalidation-images

2 similar comments
@rhjanders
Copy link
Author

/test prevalidation-images

@rhjanders
Copy link
Author

/test prevalidation-images

@rhjanders
Copy link
Author

Tagging command with output for reference:

$ ironic-tag-builds ocp-4.10 prevalidation openstack-ironic-19.0.1-0.20221012164020.455c1a9.el8
/usr/lib/python3.10/site-packages/koji/util.py:66: DeprecationWarning: krb_login is deprecated, use gssapi_login instead
warnings.warn(message, DeprecationWarning)
Validating sources...
Tagging builds...
Tagging openstack-ironic-19.0.1-0.20221012164020.455c1a9.el8 in rhaos-4.10-rhel-8-ironic-prevalidation
Watching tasks (this may be safely interrupted)...
48268419 tagBuild (noarch): free
48268419 tagBuild (noarch): free -> open (x86-032.build.eng.bos.redhat.com)
48268419 tagBuild (noarch): open (x86-032.build.eng.bos.redhat.com) -> closed
0 free 0 open 1 done 0 failed

48268419 tagBuild (noarch) completed successfully
Done!
$

@rhjanders
Copy link
Author

/test prevalidation-images

@rhjanders
Copy link
Author

/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation
/test prevalidation-e2e-metal-ipi-prevalidation

@elfosardo
Copy link

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, rhjanders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2022
@dtantsur
Copy link
Member

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 13, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2022
@rhjanders
Copy link
Author

/test images

@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2022

@rhjanders: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rhjanders
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 14, 2022
@openshift-ci-robot
Copy link

@rhjanders: This pull request references Jira Issue OCPBUGS-1740, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.10.z) matches configured target version for branch (4.10.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-2011 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-2011 targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z
  • bug has dependents

Requesting review from QA contact:
/cc @pamoedom

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from pamoedom October 14, 2022 09:42
@pamoedom
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 14, 2022
@openshift-merge-robot openshift-merge-robot merged commit 1a0826a into openshift:release-4.10 Oct 14, 2022
@openshift-ci-robot
Copy link

@rhjanders: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-1740 has been moved to the MODIFIED state.

In response to this:

This commit backports upstream changes in OpenStack/Ironic which resolve https://issues.redhat.com/browse/OCPBUGS-1740 in OpenShift 4.10:

https://review.opendev.org/c/openstack/ironic/+/859918
https://review.opendev.org/c/openstack/ironic/+/860308

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants