New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-1844: Merge from upstream metal3-io/ironic-image #321
Conversation
ServerName does not support IPv6 addresses, the verification fails when the second segment doesn't begin in a digit(it doesn't look enough like a port number). We only have a single VirtualHost per "Listen" so it is the default. Remove the use of ServerName as we're not using it to differentiate between VirtualHosts.
Removed ServerName from VirtualHost Directives
Change variable to environment
This change stops saving the OS_ prefixed variables to a file but keeps them logged on stdout. The file is not consumed elsewhere, by either this image or Ironic itself. Outputting to a container instance's stdout allows some other log collector to save what may be helpful debugging information about the Oslo configuration, and adding the: `|| true` allows for metal3-io#370's suggestion of `set -euxo pipefail` to work in cases where the environment variables are not set and grep would return non-zero.
…variables Don't log OS_ prefixed variables to a file
Add DNS or GW for use by dnsmasq
Build vbmc on CentOS Stream 9
This patch introduces some variables and improvements that can help customizing the ironic-image when building it from source. In particular, it adds the option to install ironic, ironic-inspector, or the sushy library from a gerrit refs or a commit hash.
Add variables for dhcp-host and dhcp-ignore. These allow us to specify known hosts by listing the known MACs and then telling dnsmasq to ignore any host that is not known. This is useful if running multiple instances in the same network.
add SECURITY_CONTACTS file
Allow customizing building from source
Add more DHCP options
Use local directory to build from source
Correctly support IPv6 in DNS_IP and GATEWAY_IP
Avoid unbound variables and other surprises in ironic-common
SECURITY_CONTACTS has been removed to avoid confusion. Source-based installation is still removed as well.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dtantsur: This pull request references Jira Issue OCPBUGS-1844, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@dtantsur: This pull request references Jira Issue OCPBUGS-1844, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
@dtantsur: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@dtantsur: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-1844 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
SECURITY_CONTACTS has been removed to avoid confusion.
Source-based installation is still removed as well.