Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-1844: Merge from upstream metal3-io/ironic-image #321

Merged
merged 23 commits into from Nov 24, 2022

Conversation

dtantsur
Copy link
Member

SECURITY_CONTACTS has been removed to avoid confusion.

Source-based installation is still removed as well.

derekhiggins and others added 23 commits October 7, 2022 16:01
ServerName does not support IPv6 addresses, the verification
fails when the second segment doesn't begin in a digit(it doesn't
look enough like a port number).

We only have a single VirtualHost per "Listen" so it is the default.
Remove the use of ServerName as we're not using it to differentiate
between VirtualHosts.
Removed ServerName from VirtualHost Directives
This change stops saving the OS_ prefixed variables to a file but keeps
them logged on stdout. The file is not consumed elsewhere, by either
this image or Ironic itself. Outputting to a container instance's
stdout allows some other log collector to save what may be helpful
debugging information about the Oslo configuration, and adding the:
`|| true` allows for metal3-io#370's suggestion of `set -euxo pipefail` to work
in cases where the environment variables are not set and grep would
return non-zero.
…variables

Don't log OS_ prefixed variables to a file
This patch introduces some variables and improvements that can help
customizing the ironic-image when building it from source.
In particular, it adds the option to install ironic, ironic-inspector,
or the sushy library from a gerrit refs or a commit hash.
Add variables for dhcp-host and dhcp-ignore. These allow us to specify
known hosts by listing the known MACs and then telling dnsmasq to ignore
any host that is not known. This is useful if running multiple instances
in the same network.
Use local directory to build from source
Correctly support IPv6 in DNS_IP and GATEWAY_IP
Avoid unbound variables and other surprises in ironic-common
SECURITY_CONTACTS has been removed to avoid confusion.

Source-based installation is still removed as well.
@openshift-ci
Copy link

openshift-ci bot commented Nov 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2022
@dtantsur dtantsur changed the title Merge from upstream metal3-io/ironic-image OCPBUGS-1844: Merge from upstream metal3-io/ironic-image Nov 24, 2022
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 24, 2022
@openshift-ci-robot
Copy link

@dtantsur: This pull request references Jira Issue OCPBUGS-1844, which is invalid:

  • expected the bug to target the "4.13.0" version, but it targets "4.12.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

SECURITY_CONTACTS has been removed to avoid confusion.

Source-based installation is still removed as well.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtantsur
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 24, 2022
@openshift-ci-robot
Copy link

@dtantsur: This pull request references Jira Issue OCPBUGS-1844, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @pamoedom

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from pamoedom November 24, 2022 11:24
@elfosardo
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 24, 2022

@dtantsur: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 7ce7d7d into openshift:master Nov 24, 2022
@openshift-ci-robot
Copy link

@dtantsur: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-1844 has not been moved to the MODIFIED state.

In response to this:

SECURITY_CONTACTS has been removed to avoid confusion.

Source-based installation is still removed as well.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants