New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the hash ring algorithm to SHA256 #94
Conversation
The default MD5 is not compatible with FIPS mode. See https://bugzilla.redhat.com/show_bug.cgi?id=1853302 Upstream: metal3-io#179
@@ -17,6 +17,8 @@ enabled_raid_interfaces = no-raid,irmc,agent,fake | |||
enabled_vendor_interfaces = ipmitool,no-vendor,idrac,fake | |||
rpc_transport = json-rpc | |||
use_stderr = true | |||
# NOTE(dtantsur): the default md5 is not compatible with FIPS mode | |||
hash_ring_algorithm = sha256 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this influence hashes which end up in the DB? I'm just wondering of the upgrade implications if the ironic containers get restarted but not mariadb?
In practice on a major upgrade I guess they will all restart, but I wanted to be sure what the impact would be, e.g do we need to verify/enforce that to purge the ephemeral DB?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, hashes only exist in memory (generated from host names in the DB, which are dynamic).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok thanks for clarifying!
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur, hardys The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
15 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Enable redfish driver
The default MD5 is not compatible with FIPS mode. See
https://bugzilla.redhat.com/show_bug.cgi?id=1853302
Upstream: metal3-io#179