Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1764460: Re-ordering some plugins in alphabetical order #973

Conversation

akram
Copy link
Contributor

@akram akram commented Nov 4, 2019

This is a fake fix to allo the tracker for bz-1764460 to be updated

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 4, 2019
@openshift-ci-robot
Copy link
Contributor

@akram: This pull request references Bugzilla bug 1764460, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1764460: Re-ordering some plugins in alphabetical order

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 4, 2019
@waveywaves
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akram, waveywaves

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akram
Copy link
Contributor Author

akram commented Nov 4, 2019

/retest

@akram
Copy link
Contributor Author

akram commented Nov 4, 2019

/test e2e-aws

1 similar comment
@akram
Copy link
Contributor Author

akram commented Nov 4, 2019

/test e2e-aws

@akram
Copy link
Contributor Author

akram commented Nov 4, 2019

/retest

@akram
Copy link
Contributor Author

akram commented Nov 4, 2019

/test e2e-aws

@akram
Copy link
Contributor Author

akram commented Nov 4, 2019

some big flakes with AWS volumes and pssibily preventing router metrics to be available

/retest

@akram
Copy link
Contributor Author

akram commented Nov 5, 2019

/test e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit 04be87c into openshift:master Nov 5, 2019
@openshift-ci-robot
Copy link
Contributor

@akram: All pull requests linked via external trackers have merged. Bugzilla bug 1764460 has been moved to the MODIFIED state.

In response to this:

Bug 1764460: Re-ordering some plugins in alphabetical order

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akram
Copy link
Contributor Author

akram commented Nov 18, 2019

/cherry-pick release-4.2

@openshift-cherrypick-robot

@akram: #973 failed to apply on top of branch "release-4.2":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	2/contrib/openshift/base-plugins.txt
Falling back to patching base and 3-way merge...
Auto-merging 2/contrib/openshift/base-plugins.txt
CONFLICT (content): Merge conflict in 2/contrib/openshift/base-plugins.txt
Patch failed at 0001 Re-ordering some plugins in alphabetical order

In response to this:

/cherry-pick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants