OCPBUGS-63482: UPSTREAM: <carry>: extend loopback certificate validity to three years #73
Conversation
| // - https://issues.redhat.com/browse/OCPBUGS-61760 | ||
| // - https://issues.redhat.com/browse/OCPBUGS-61759 | ||
| // Achieves the same result as the upstream change in https://github.com/kubernetes/kubernetes/pull/130047 | ||
| maxAge := time.Hour * 24 * (3 * 365 + 1) // one year self-signed certs |
There was a problem hiding this comment.
| maxAge := time.Hour * 24 * (3 * 365 + 1) // one year self-signed certs | |
| maxAge := time.Hour * 24 * (3 * 365 + 1) // three year self-signed certs |
| // NOTE: As part of the work to resolve https://issues.redhat.com/browse/OCPBUGS-61760 | ||
| // and https://issues.redhat.com/browse/OCPBUGS-61759 it was decided that copying | ||
| // the loopback certification creation utility function to a local | ||
| // utility function would save significant effort over cherry-picking | ||
| // the fix from https://github.com/kubernetes/kubernetes/pull/130047 to | ||
| // https://github.com/openshift/kubernetes-client-go . | ||
| // We don't expect to backport many changes on top of this and it seemed | ||
| // lower risk than switching impacted modules to our fork of client-go. |
There was a problem hiding this comment.
I think I'd introduce a brand new file in this directory to contain the source of the forked function to isolate the diff surface here to just the line that calls GenerateSelfSignedCertKey.
| // NOTE: Modified from the original of 1 year to 3 years to fix | ||
| // - https://issues.redhat.com/browse/OCPBUGS-61760 | ||
| // - https://issues.redhat.com/browse/OCPBUGS-61759 | ||
| // Achieves the same result as the upstream change in https://github.com/kubernetes/kubernetes/pull/130047 | ||
| maxAge := time.Hour * 24 * (3 * 365 + 1) // one year self-signed certs |
There was a problem hiding this comment.
This line is the only one changed from the copy-pasted client-go code.
everettraven
force-pushed
the
bugfix/loopback-cert-3years
branch
from
5ef7fd2 to
66e0441
Compare
everettraven
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@everettraven: This pull request references Jira Issue OCPBUGS-63482, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
everettraven
force-pushed
the
bugfix/loopback-cert-3years
branch
from
66e0441 to
3771ecd
Compare
3 participants
Updates the loopback certificate generation logic to extend the certificate validity to three years as a basis to fix both https://issues.redhat.com/browse/OCPBUGS-61760 and https://issues.redhat.com/browse/OCPBUGS-61759.