New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2043043: Rebase Autoscaler onto upstream release-1.23 branch #218
Bug 2043043: Rebase Autoscaler onto upstream release-1.23 branch #218
Conversation
Bring AWS fallback hardcoded list of instances up to date to 30/08/21
It looks like it belongs inside the class, not with code using it.
…er election is based off configmaps
…lect-resource-lock-role fix(leader-elect-resource-lock-role): Add permissions to role if leader election is based off configmaps
fix edge-case in extraArgs bump chart version
…-Examples-List-NS-RBAC CA - Cloud Provider Examples - add ability to list/watch/get namespaces
fix: add missing RBAC permissions to example spec
Add a test for clusterStateFeeder.InitFromHistoryProvider
…ist-Update-08/21 Cluster-Autoscaler - Update hardcoded AWS instance list
1. IsRetryableAPIError is no longer needed, stop using it kubernetes/kubernetes#95495 2. LogClusterImageSources is now private, stop using it kubernetes/kubernetes#89676 3. DeleteResourceAndWaitForGC was moved 4. k8s.io/kubernetes/test/e2e/manifest was moved
Update VPA e2e dependencies
…r-helmchart-4297 [CA][HELM]fix not being able to set args without value
[ca] Update AWS docs for ASG tags
…essor Move GetNodeInfosForGroups to it's own processor
Every other processors (and, I think, function in CA?) that takes AutoscalingContext has it as first parameter. Changing the new processor for consistency.
Cluster Autoscaler: GCE: Add support for Spot VMs
Change parameter order of TemplateNodeInfoProvider
Update k8s dependencies to 1.23.0-alpha.1 in CA.
Use custom spam filtering function in event recorder.
Use a list of structs instead of a list of strings to choose recommenders. This will allow us to pass parameters to recommenders (if we decide we want to allow that). Related to kubernetes#3913
Make logs about managing cache less verbose
i examined the commit history on my local machine and i do see the commits i expect to be on top. the history does look a little different than what i've seen in the past, but i think as long as we are passing the tests and our carry commits are the most recent then i'm good to approve this. i think it would be nice for our next rebase, to squash the art commits together. i have a feeling that we will need to have some manual maintenance done on the autoscaler rebases in the future. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retest |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/override ci/prow/e2e-aws-operator I've spent some time investigating the failing tests this morning and believe they are not the result of this PR. They have been failing for some time and I will add bugs for the team to resolve the individual test failures in the near future |
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-operator In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retitle Bug 2043043: Rebase Autoscaler onto upstream release-1.23 branch |
@cloud-team-rebase-bot[bot]: This pull request references Bugzilla bug 2043043, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ci/prow/e2e-aws-operator |
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-operator In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@cloud-team-rebase-bot[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@cloud-team-rebase-bot[bot]: All pull requests linked via external trackers have merged: Bugzilla bug 2043043 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
why did this PR overwrote the default API group 6cbeaf3#diff-c8813a0942bbcd464aaa04a04c2c71897d5df30b65a2db86cb81773016f24406R47? |
i think this was a simple mistake on our part. we did not intentionally overwrite the default. i have created #220 to address the issue for now. |
…-master Bug 2043043: Rebase Autoscaler onto upstream release-1.23 branch
No description provided.