Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2043043: Rebase Autoscaler onto upstream release-1.23 branch #218

Merged

Conversation

cloud-team-rebase-bot[bot]
Copy link

No description provided.

gjtempleton and others added 30 commits August 30, 2021 22:32
Bring AWS fallback hardcoded list of instances up to date to 30/08/21
It looks like it belongs inside the class, not with code using it.
…lect-resource-lock-role

fix(leader-elect-resource-lock-role): Add permissions to role if leader election is based off configmaps
fix edge-case in extraArgs

bump chart version
…-Examples-List-NS-RBAC

CA - Cloud Provider Examples - add ability to list/watch/get namespaces
fix: add missing RBAC permissions to example spec
Add a test for clusterStateFeeder.InitFromHistoryProvider
…ist-Update-08/21

Cluster-Autoscaler - Update hardcoded AWS instance list
1. IsRetryableAPIError is no longer needed, stop using it
kubernetes/kubernetes#95495
2. LogClusterImageSources is now private, stop using it
kubernetes/kubernetes#89676
3. DeleteResourceAndWaitForGC was moved
4. k8s.io/kubernetes/test/e2e/manifest was moved
…r-helmchart-4297

[CA][HELM]fix not being able to set args without value
…essor

Move GetNodeInfosForGroups to it's own processor
Every other processors (and, I think, function in CA?) that takes
AutoscalingContext has it as first parameter. Changing the new processor
for consistency.
Cluster Autoscaler: GCE: Add support for Spot VMs
Change parameter order of TemplateNodeInfoProvider
Update k8s dependencies to 1.23.0-alpha.1 in CA.
Use custom spam filtering function in event recorder.
Use a list of structs instead of a list of strings to choose
recommenders.

This will allow us to pass parameters to recommenders (if we decide we
want to allow that).

Related to kubernetes#3913
Make logs about managing cache less verbose
@elmiko
Copy link

elmiko commented Jan 19, 2022

i examined the commit history on my local machine and i do see the commits i expect to be on top. the history does look a little different than what i've seen in the past, but i think as long as we are passing the tests and our carry commits are the most recent then i'm good to approve this.

i think it would be nice for our next rebase, to squash the art commits together. i have a feeling that we will need to have some manual maintenance done on the autoscaler rebases in the future.

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jan 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2022
@JoelSpeed
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2022
@JoelSpeed
Copy link

/retest

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@JoelSpeed
Copy link

/override ci/prow/e2e-aws-operator

I've spent some time investigating the failing tests this morning and believe they are not the result of this PR. They have been failing for some time and I will add bugs for the team to resolve the individual test failures in the near future

@openshift-ci
Copy link

openshift-ci bot commented Jan 20, 2022

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-operator

In response to this:

/override ci/prow/e2e-aws-operator

I've spent some time investigating the failing tests this morning and believe they are not the result of this PR. They have been failing for some time and I will add bugs for the team to resolve the individual test failures in the near future

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@JoelSpeed
Copy link

/retitle Bug 2043043: Rebase Autoscaler onto upstream release-1.23 branch

@openshift-ci openshift-ci bot changed the title Merge https://github.com/kubernetes/autoscaler:master into master Bug 2043043: Rebase Autoscaler onto upstream release-1.23 branch Jan 20, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 20, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jan 20, 2022

@cloud-team-rebase-bot[bot]: This pull request references Bugzilla bug 2043043, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

Bug 2043043: Rebase Autoscaler onto upstream release-1.23 branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoelSpeed
Copy link

/override ci/prow/e2e-aws-operator

@openshift-ci
Copy link

openshift-ci bot commented Jan 20, 2022

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-operator

In response to this:

/override ci/prow/e2e-aws-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jan 20, 2022

@cloud-team-rebase-bot[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator 6cbeaf3 link false /test e2e-gcp-operator
ci/prow/git-history 6cbeaf3 link false /test git-history
ci/prow/goimports 6cbeaf3 link false /test goimports
ci/prow/e2e-azure-operator 6cbeaf3 link false /test e2e-azure-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 112a8b0 into openshift:master Jan 20, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jan 20, 2022

@cloud-team-rebase-bot[bot]: All pull requests linked via external trackers have merged:

Bugzilla bug 2043043 has been moved to the MODIFIED state.

In response to this:

Bug 2043043: Rebase Autoscaler onto upstream release-1.23 branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@enxebre
Copy link
Member

enxebre commented Jan 25, 2022

why did this PR overwrote the default API group 6cbeaf3#diff-c8813a0942bbcd464aaa04a04c2c71897d5df30b65a2db86cb81773016f24406R47?
cc @elmiko @JoelSpeed

@elmiko
Copy link

elmiko commented Jan 25, 2022

why did this PR overwrote the default API group

i think this was a simple mistake on our part. we did not intentionally overwrite the default. i have created #220 to address the issue for now.

Fedosin pushed a commit to Fedosin/kubernetes-autoscaler that referenced this pull request May 25, 2022
…-master

Bug 2043043: Rebase Autoscaler onto upstream release-1.23 branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet