[release-4.18] OCPBUGS-63605: refactor cloud provider options #389
Conversation
refactor core.AutoscalerOptions in a new package This change helps to prevent circular dependencies between the core and builder packages as we start to pass the AutoscalerOptions to the cloud provider builder functions. refactor NewCloudProvider to accept AutoscalerOptions this changes the options input to the cloud provider builder function so that the full autoscaler options are passed. This is being proposed so that cloud providers will have new options for injecting behavior into the core parts of the autoscaler. add RegisterCombinedScaledDownCandidateProcessor util function to help cloud providers in adding additional combined scale down processors. add clusterapi scale down upgrade processor This change adds a custom scale down node processor for cluster api to reject nodes that are undergoing upgrade. ensure cloud provider is initalized last this change moves the cloud provider initialization to the end of the initializeDefaultOptions function to ensure that all other options are prepared before the cloud provider. Due to the cloud provider now receiving the full AutoscalerOptions struct, we need to ensure that all the data is available. refactor gpu_processor_test to remove cyclic dependency this change removes the import from the gce module in favor of using the string value directly.
openshift-ci-robot
added
jira/severity-critical
|
@elmiko: This pull request references Jira Issue OCPBUGS-63605, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
elmiko
changed the title
|
/test e2e-aws-periodic-pre |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws-periodic-pre |
1 similar comment
|
/test e2e-aws-periodic-pre |
|
i'm a little concerned about the failures in e2e-aws-periodic-pre. it looks like slow machine creation might be causing the failures. /retest |
|
/retest |
|
still seeing scale out errors, but i think it's slow infra. /retest |
|
/retest |
|
@elmiko: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
this change refactors how cloud providers are created so that providers can inject a custom scale down processor. it also adds an upgrade processor for cluster-api to allow skipping machinedeployments that are undergoing upgrade.