New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1990190: Remove Error Message Check Dynamic PV Tests #1011
Bug 1990190: Remove Error Message Check Dynamic PV Tests #1011
Conversation
@iamemilio: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
Different CSI drivers have different error messages, making it difficult to check them accurately. We remove the check for the error message and only check the failure type instead, since that is all we need.
029d7ae
to
66a5682
Compare
@iamemilio: the contents of this pull request could be automatically validated. The following commits are valid:
|
/retest |
1 similar comment
/retest |
/retest e2e-openstack-csi-manila |
@EmilienM: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-openstack-csi-manila |
/assign @soltysh |
@iamemilio: This pull request references Bugzilla bug 1990190, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamemilio, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@iamemilio: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1990190 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Different CSI drivers have different error messages, making it difficult
to check them accurately. We remove the check for the error message and
only check the failure type instead, since that is all we need.
/kind bug
/kind failing-test
cherry-pick backport: kubernetes#105612