New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2077004: Rebase 1.21.11 #1246
Bug 2077004: Rebase 1.21.11 #1246
Conversation
Ensure resources are created in zone with schedulable nodes. For example, if we have 4 zones with 3 zones having worker nodes and 1 zone having master nodes(unscheduable for workloads), we should not create resources like PV, PVC or pods in that zone.
See grpc/grpc-go#4758 for a real world example of this leaking 2gb+ of data. Basically, when we do `q.queue[1:]` we are just repositioning the slice. The underlying array is still active, which contains the object formerly known as `q.queue[0]`. Because its referencing this object, it will not be GCed. The only thing that will trigger it to free is eventually when we add enough to the queue that we allocate a whole new array. Instead, we should explicitly clear out the old space when we remove it from the queue. This ensures the object can be GCed, assuming the users' application doesn't reference it anymore.
When UnmountDevice fails, kubelet treat the volume mount as uncertain, because it does not know at which stage UnmountDevice failed. It may be already partially unmonted / destroyed. As result, MountDevice will be performer when a new Pod is started on the node after UnmountDevice faiure.
…ere unmounted podVolumesExist() should consider also uncertain volumes (where kubelet does not know if a volume was fully unmounted) when checking for pod's volumes. Added GetPossiblyMountedVolumesForPod for that. Adding uncertain mounts to GetMountedVolumesForPod would potentially break other callers (e.g. `verifyVolumesMountedFunc`).
To know when a volume has been fully unmounted (incl. uncertain mounts).
Change existing desiredStateOfWorldPopulator.findAndAddNewPods tests to use a common initialization function.
desiredStateOfWorldPopulator.findAndRemoveDeletedPods() should remove volumes from DSW when a pod is deleted on the API server and the volume is uncertain in ASW.
This is a fix for the issue kubernetes#97031. It may happen that a subpath mount point on a networking FS gets deleted on the server but in the case of some file systems (CIFS) it would make the stat syscall end with ENOENT, preventing the mount point to be cleaned up and pods using the mount can't be cleanly deleted. This situation can be detected by calling also access syscall on the same path: if there is a discrepancy between stat and access results, treating the mount as corrupted allows for successful cleanup and unmount.
should mark volume mount in actual state even if volume expansion fails so that reconciler can tear down the volume when needed. To avoid pods start using it, mark volume as uncertain instead of mounted. Will add unit test after the logic is reviewed. Change-Id: I5aebfa11ec93235a87af8f17bea7f7b1570b603d
…-of-#104799-upstream-release-1.21 Automated cherry pick of kubernetes#104799: fix the error when cleaning up jobs for cronjob
Signed-off-by: Rodrigo Campos <rodrigo@kinvolk.io>
Signed-off-by: Rodrigo Campos <rodrigo@kinvolk.io>
…ick-of-#107091-upstream-release-1.21 Automated cherry pick of kubernetes#107091: Improving performance of EndpointSlice controller metrics
API server rejects continuations with ResourceVersionMatch set.
Implement the test cleanup callback method to close any open vSphere client connections. Without this clean up sessions were leaking during testing.
…k-of-#107221-upstream-release-1.21 Automated cherry pick of kubernetes#107221: fix nil pointer in create secret commands
Cherry pick of anp 0.0.27 for v1.21
The problem with e2e-metal-ipi-ovn-ipv6 is being tracked in https://bugzilla.redhat.com/show_bug.cgi?id=2076809 |
@soltysh: Overrode contexts on behalf of soltysh: ci/prow/verify-commits In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: josefkarasek, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/label cherry-pick-approved |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/hold |
/hold cancel |
@josefkarasek: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@josefkarasek: All pull requests linked via external trackers have merged: Bugzilla bug 2077004 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This fix contains the following changes coming from updated version of kubernetes up to v1.21.11:
Changelog:
v1.21.11: https://github.com/kubernetes/kubernetes/blob/release-1.21/CHANGELOG/CHANGELOG-1.21.md#downloads-for-v12111
v1.21.10: https://github.com/kubernetes/kubernetes/blob/release-1.21/CHANGELOG/CHANGELOG-1.21.md#downloads-for-v12110
v1.21.9: https://github.com/kubernetes/kubernetes/blob/release-1.21/CHANGELOG/CHANGELOG-1.21.md#downloads-for-v1219