Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2086092: update kube to v1.24.0 #1252

Merged
merged 2,679 commits into from May 26, 2022
Merged

Conversation

tkashem
Copy link

@tkashem tkashem commented May 4, 2022

No description provided.

liggitt and others added 30 commits March 31, 2022 08:15
Revert "Field `status.hostIPs` added for Pod (kubernetes#101566)"
Some Azure regions do not have any availability zones. Nodes in such zones have
these labels, where "0" is a fault domain, not an availability zone.

  "topology.kubernetes.io/region": "westus"
  "topology.kubernetes.io/zone": "0"

Azure Disk CSI driver uses zone "" in this case:
  "topology.disk.csi.azure.com/zone": ""

Fix the CSI translation to translate the fault domain "0" to "". Any value that is just
a number and not "<region>-<number>" ("centralus-1") needs to be translated to
"" in similar fashion.
Fix non-enum CSR condition field, omit enums from static openapi snapshot
Fix copylock vet errors in component-base metrics
Exercise defaulting tests with/without features enabled
…r-migration-v1-api

v1 types for Leader Migration
…ted_requests

Fix the overestimated cost of deletaged API requests in P&F
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
Add sync_proxy_rules_no_endpoints_total metric
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
compact scheduling failure msg for taint/toleration mismatch
set parallelism in integration tests using GOMAXPROCS
…dation-tests

Flake fix: validate each expression once in primary CEL correctness suite
…me-data-structures-from-gotestsum

Correctly attribute some data structures from gotestsum repository
stlaz and others added 13 commits May 25, 2022 23:31
In the tests, we oftentimes create pods directly by the administrative
user and so their SCC-related privileges are being used to create the
pods. The PSa label syncher however works by introspecting SAs in each
namespace, and since the SAs in the direct pod creation use-cases don't
have the SCC-related privileges, the labelsyncer evaluates these
namespaces as "restricted" because only the "restricted-v2" SCC is ever
assigned in the namespaces. This breaks tests where pods are created
directly.

openshift-rebase(v1.24):source=35dc012e1f5
we encountered a vendor inconsistency error from staging/src/k8s.io/code-generator.
in order to fix it:
- change direcroty to 'staging/src/k8s.io/code-generator/examples'
- open go.mod and add openshift ginkgo in a replace section
  replace (
     github.com/onsi/ginkgo => github.com/openshift/ginkgo origin-4.7
  )
- go mod tidy

- change directory to 'staging/src/k8s.io/code-generator'
- open go.mod and add openshift ginkgo in a replace section
  replace (
    github.com/onsi/ginkgo => github.com/openshift/ginkgo origin-4.7
  )
- go mod tidy
- go mod vendor

- change directory to root of the repo
- bump the following openshift repos in the go.mod file
     - openshift/api
     - openshift/client-go
     - openshift/library-go
     - openshift/apiserver-library-go
     - github.com/openshift/ginkgo origin-4.7

- go mod tidy
- hack/update-vendor.sh
when we run verify-import-boss.sh it fails with the following error

errors in package "k8s.io/kubernetes/cmd/kubeadm/app/phases/bootstraptoken/node":
the following imports did not match any allowed prefix:
  gopkg.in/yaml.v3
  k8s.io/kube-openapi/pkg/validation/spec

note: this should be an upstream fix, not sure why we don't see this
error in upstream, does upstream not run this job in verify?
investigate and take proper action for this commit
make update fails with the following error due to some go mod issue
in code-generator:
```
inconsistent vendoring in /go/{redacted}/k8s.io/code-generator
```

to work around, we do the following:

- change directory to 'staging/src/k8s.io/code-generator'
- remove the following from the 'replace' section
	 k8s.io/code-generator => ../code-generator
- run 'go mod tidy'
- run 'go mod vendor'

- change directory to root
- run make update, using the following command

podman run -it --rm -v $( pwd ):/go/src/k8s.io/kubernetes:Z \
  --workdir=/go/src/k8s.io/kubernetes \
  registry.ci.openshift.org/openshift/release:rhel-8-release-golang-1.18-openshift-4.11 \
  make update OS_RUN_WITHOUT_DOCKER=yes

inside the docker prompt, also run the followig:
- OS_RUN_WITHOUT_DOCKER=yes hack/update-generated-pod-resources.sh
due to the following inconsistent vendoring error:
  go: inconsistent vendoring in /go/src/k8s.io/kubernetes/hack/tools:

we need to do the following steps:
- change directory to 'hack/tools'
- run 'go mod tidy'
- run 'go mod vendor'
- run 'update-netparse-cve.sh'

if you are inside the container, then:
OS_RUN_WITHOUT_DOCKER=yes hack/update-netparse-cve.sh
due to the following inconsistent vendoring error:
go: inconsistent vendoring in /go/src/k8s.io/kubernetes/hack/tools:

we need to do the following steps:
- change directory to 'hack/tools'
- run 'go mod tidy'
- run 'go mod vendor'
- run 'update-mocks.sh'

if you are inside the container, then:
OS_RUN_WITHOUT_DOCKER=yes hack/update-mocks.sh

we also need to check in the vendr folder, otherwise the verify
mock job will fail in ci

note: why does verify mocks fail with upstream file that we have not
changed? further investigate warranted.
due to the following inconsistent vendoring error:
  go: inconsistent vendoring in /go/src/k8s.io/kubernetes/hack/tools:

we run make update by removing the following from replace
section of code-generator go.mod file
  k8s.io/code-generator => ../code-generator

so after we complete all 'update', we run hack/update-vendor.sh

once we solve the dependency issue with downstream then this
would no longer be needed
- disable 'ProxyTerminatingEndpoints' feature e2e tests

- disable [sig-network] [Feature:Topology Hints] should distribute endpoints evenly
see https://bugzilla.redhat.com/show_bug.cgi?id=2079958 for more context
@openshift-ci-robot
Copy link

@tkashem: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@tkashem
Copy link
Author

tkashem commented May 26, 2022

/retest

@deads2k deads2k merged commit 01aa0f3 into openshift:master May 26, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 26, 2022

@tkashem: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2086092 has not been moved to the MODIFIED state.

In response to this:

Bug 2086092: update kube to v1.24.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented May 26, 2022

@tkashem: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack fa00c301093bd35dec8a495dc7b6a6de8fc06cf5 link false /test e2e-openstack
ci/prow/verify-commits 3f9aaab link true /test verify-commits

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet