Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1881688: UPSTREAM: 94984: check readyz before adding endpoint for kube-apiserver #371

Merged

Conversation

deads2k
Copy link

@deads2k deads2k commented Sep 22, 2020

probably leading to messages that dan williams will post.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2020
@dcbw dcbw changed the title UPSTREAM 94984: check readyz before adding endpoint for kube-apiserver Bug 1881688: UPSTREAM 94984: check readyz before adding endpoint for kube-apiserver Sep 22, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 22, 2020
@openshift-ci-robot
Copy link

@deads2k: This pull request references Bugzilla bug 1881688, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1881688: UPSTREAM 94984: check readyz before adding endpoint for kube-apiserver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Member

dcbw commented Sep 22, 2020

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_ovn-kubernetes/279/pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn/1308197296986394624

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_ovn-kubernetes/279/pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn/1308197296986394624/artifacts/e2e-aws-ovn/pods/openshift-kube-apiserver_kube-apiserver-ip-10-0-135-248.us-west-1.compute.internal_kube-apiserver.log

W0922 01:26:24.685077 19 patch_genericapiserver.go:119] Request to "/apis/discovery.k8s.io/v1beta1" (source IP 10.0.249.79:23149, user agent "kube-controller-manager/v1.19.0 (linux/amd64) kubernetes/7e8389f/system:serviceaccount:kube-system:namespace-controller") before server is ready, possibly a sign for a broken load balancer setup.

apiserver logs are filled with these messages over long periods of time.

@dcbw dcbw changed the title Bug 1881688: UPSTREAM 94984: check readyz before adding endpoint for kube-apiserver Bug 1881688: UPSTREAM: 94984: check readyz before adding endpoint for kube-apiserver Sep 23, 2020
@dcbw
Copy link
Member

dcbw commented Sep 23, 2020

/retest

@dcbw
Copy link
Member

dcbw commented Sep 23, 2020

@deads2k commit seems to need a : between UPSTREAM and the PR#

@sttts
Copy link

sttts commented Sep 23, 2020

/retest

@sttts
Copy link

sttts commented Sep 23, 2020

Misnamed commit.

@sttts
Copy link

sttts commented Sep 23, 2020

/lgtm
/bugzilla-refresh

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2020
@deads2k
Copy link
Author

deads2k commented Sep 23, 2020

was green and tagged. fixed commit name. No conflict with abu's metrics. Merging.

@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit fff8183 into openshift:master Sep 23, 2020
@openshift-ci-robot
Copy link

@deads2k: All pull requests linked via external trackers have merged:

Bugzilla bug 1881688 has been moved to the MODIFIED state.

In response to this:

Bug 1881688: UPSTREAM: 94984: check readyz before adding endpoint for kube-apiserver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants