Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1868645: UPSTREAM: 94087: kubelet: node sync at least once #522

Merged
merged 2 commits into from Jan 29, 2021

Conversation

ehashman
Copy link

Sync node at least once, avoiding pods getting stuck in NodeAffinity status.

Upstream bug: kubernetes#92067
Upstream PR: kubernetes#94087
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1868645

/cc @rphillips @mrunalp

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Jan 13, 2021
@openshift-ci-robot
Copy link

@ehashman: This pull request references Bugzilla bug 1868645, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1868645: UPSTREAM: 94087: kubelet: node sync at least once

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 13, 2021
@ehashman
Copy link
Author

/retest

@ehashman
Copy link
Author

running into a lot of https://bugzilla.redhat.com/show_bug.cgi?id=1891068 flakes + VPC quota limits on AWS. Will retry just the GCP ones for now

/test e2e-gcp
/test e2e-gcp-upgrade

@ehashman
Copy link
Author

/hold

let's wait until we get the logspam patch in kubernetes#98137

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2021
@ehashman
Copy link
Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2021
@nee1esh
Copy link

nee1esh commented Jan 21, 2021

/retest

5 similar comments
@ehashman
Copy link
Author

/retest

@ehashman
Copy link
Author

/retest

@ehashman
Copy link
Author

/retest

@ehashman
Copy link
Author

/retest

@ehashman
Copy link
Author

/retest

@ehashman
Copy link
Author

We might want to override the e2e-agnostic-cmd test, it's failing for everyone. https://prow.ci.openshift.org/job-history/gs/origin-ci-test/pr-logs/directory/pull-ci-openshift-origin-master-e2e-agnostic-cmd

@rphillips @mrunalp would you PTAL? :)

@nee1esh
Copy link

nee1esh commented Jan 29, 2021

/retest

@rphillips
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2021
@sjenning
Copy link

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, rphillips, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@ehashman
Copy link
Author

/test k8s-e2e-gcp
flake

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link

openshift-ci bot commented Jan 29, 2021

@ehashman: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-agnostic-cmd a6a4a10 link /test e2e-agnostic-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3b90e69 into openshift:master Jan 29, 2021
@openshift-ci-robot
Copy link

@ehashman: All pull requests linked via external trackers have merged:

Bugzilla bug 1868645 has been moved to the MODIFIED state.

In response to this:

Bug 1868645: UPSTREAM: 94087: kubelet: node sync at least once

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ehashman
Copy link
Author

/cherry-pick release-4.6

@openshift-cherrypick-robot

@ehashman: new pull request created: #582

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants