Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1885717: UPSTREAM: 98742: Sync completed pods until their containers have been terminated #593

Merged
merged 1 commit into from Feb 25, 2021

Conversation

harche
Copy link

@harche harche commented Feb 25, 2021

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR allows the kubelet to synchronize completed pods until their containers have been terminated.

If a pod was evicted, its containerStatuses were out of sync because dispatchWork did ignore works of the pods having completed.

Which issue(s) this PR fixes:

Fixes # https://bugzilla.redhat.com/show_bug.cgi?id=1885717

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Feb 25, 2021
@openshift-ci-robot
Copy link

@harche: This pull request references Bugzilla bug 1885717, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1885717: UPSTREAM: Sync completed pods until their containers have been terminated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 25, 2021
@openshift-ci-robot
Copy link

@harche: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot
Copy link

@harche: the contents of this pull request could be automatically validated.

The following commits are valid:

@openshift-ci-robot openshift-ci-robot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Feb 25, 2021
@harche harche changed the title Bug 1885717: UPSTREAM: Sync completed pods until their containers have been terminated Bug 1885717: UPSTREAM: 98742: Sync completed pods until their containers have been terminated Feb 25, 2021
@harche
Copy link
Author

harche commented Feb 25, 2021

/assign

@harche
Copy link
Author

harche commented Feb 25, 2021

/cc @rphillips

@rphillips
Copy link

/retest
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2021
@mrunalp mrunalp added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: harche, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1ce30fc into openshift:master Feb 25, 2021
@openshift-ci-robot
Copy link

@harche: All pull requests linked via external trackers have merged:

Bugzilla bug 1885717 has been moved to the MODIFIED state.

In response to this:

Bug 1885717: UPSTREAM: 98742: Sync completed pods until their containers have been terminated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harche
Copy link
Author

harche commented Feb 25, 2021

/cherry-pick release-4.7

@harche harche deleted the bug_1885717 branch February 25, 2021 16:31
@openshift-cherrypick-robot

@harche: new pull request created: #595

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants