New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: 103050: Bug 1975325: Fix NodeAuthenticator tests in dual stack #823
UPSTREAM: 103050: Bug 1975325: Fix NodeAuthenticator tests in dual stack #823
Conversation
@ardaguclu: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
@ardaguclu: This pull request references Bugzilla bug 1975325, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
d9e275a
to
5425a57
Compare
@ardaguclu: the contents of this pull request could be automatically validated. The following commits are valid:
|
/retest |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
@ardaguclu: All pull requests linked via external trackers have merged: Bugzilla bug 1975325 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.8 |
@ardaguclu: new pull request created: #840 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
NodeAuthenticator tests are failing in dualstack.
Special notes for your reviewer:
In dualstack, nodes have both IPv4 and IPv6 ip addresses assigned. But Kubelet starts metrics server just picking one of them(first one in the
--node-ip
). However, NodeAuthenticator tests try to send requests to all of IP addresses and these tests are failing in dualstack. This PR filters node IPs according to the first IP family(which kubelet starts server to listen).This test will fail for IPv6 until openshift/origin#26140 is merged. However, this PR can be safely merged, because these two tests have not been enabled for IPv6 configuration yet.