Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1977383: Update resource quota test for compatibility with service ca configmap publishing #839

Merged

Conversation

marun
Copy link

@marun marun commented Jul 1, 2021

Update the resource quota configmap conformance test in anticipation of the publication of openshift-service-ca.crt configmap in every namespace by #834. This change will need to be vendored into origin before e2e will pass against 834.

As of 1.21 (4.8 and above), the test in question sets the test resource quota for configmaps to 10, so this fix is not required for release-4.8 or master.

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jul 1, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jul 1, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 1, 2021

@marun: This pull request references Bugzilla bug 1977383, which is invalid:

  • expected dependent Bugzilla bug 1977179 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
  • expected dependent Bugzilla bug 1977756 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
  • expected dependent Bugzilla bug 1977756 to target a release in 4.8.0, but it targets "2.6.6" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1977383: Update resource quota test for compatibility with service ca configmap publishing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 1, 2021
@openshift-ci-robot
Copy link

@marun: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci openshift-ci bot requested review from deads2k and mfojtik July 1, 2021 05:02
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2021
@sttts sttts removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jul 1, 2021
@sttts
Copy link

sttts commented Jul 1, 2021

/bugzilla refresh
/lgtm

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 1, 2021
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 1, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 1, 2021

@sttts: This pull request references Bugzilla bug 1977383, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1946479 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1946479 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

Requesting review from QA contact:
/cc @wangke19

In response to this:

/bugzilla refresh
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from wangke19 July 1, 2021 07:49
@openshift-ci
Copy link

openshift-ci bot commented Jul 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sttts
Copy link

sttts commented Jul 1, 2021

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@sttts
Copy link

sttts commented Jul 1, 2021

This PR only changes one package of e2e tests (resource quota). The flakes are unrelated. As this is critical, will override.

@sttts
Copy link

sttts commented Jul 1, 2021

/override ci/prow/e2e-aws-jenkins
/override ci/prow/e2e-aws-serial

@openshift-ci
Copy link

openshift-ci bot commented Jul 1, 2021

@sttts: Overrode contexts on behalf of sttts: ci/prow/e2e-aws-jenkins, ci/prow/e2e-aws-serial

In response to this:

/override ci/prow/e2e-aws-jenkins
/override ci/prow/e2e-aws-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 1, 2021
@sdodson
Copy link
Member

sdodson commented Jul 1, 2021

Approving a test only change in order to tee-up the real change in #834

@openshift-merge-robot openshift-merge-robot merged commit c3d8a1c into openshift:release-4.7 Jul 1, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 1, 2021

@marun: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1977383 has not been moved to the MODIFIED state.

In response to this:

Bug 1977383: Update resource quota test for compatibility with service ca configmap publishing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants