Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.8] bug 1981633: UPSTREAM: <carry>: add a way to inject a vulnerable, legacy service-c… #856

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #852

/assign deads2k

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci openshift-ci bot requested review from deads2k and sttts July 13, 2021 06:48
@stlaz
Copy link
Member

stlaz commented Jul 13, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2021
@deads2k
Copy link

deads2k commented Jul 13, 2021

/retest
/approve
/hold for proof in openshift/cluster-kube-controller-manager-operator#546

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2021
@deads2k deads2k removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jul 13, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, openshift-cherrypick-robot, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2021
@deads2k deads2k changed the title [release-4.8] UPSTREAM: <carry>: add a way to inject a vulnerable, legacy service-c… [release-4.8] bug 1981634: UPSTREAM: <carry>: add a way to inject a vulnerable, legacy service-c… Jul 13, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jul 13, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 13, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1981634, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.8] bug 1981634: UPSTREAM: : add a way to inject a vulnerable, legacy service-c…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 13, 2021
@deads2k deads2k changed the title [release-4.8] bug 1981634: UPSTREAM: <carry>: add a way to inject a vulnerable, legacy service-c… [release-4.8] bug 1981633: UPSTREAM: <carry>: add a way to inject a vulnerable, legacy service-c… Jul 13, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 13, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1981633, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead
  • expected dependent Bugzilla bug 1981634 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is NEW instead
  • expected dependent Bugzilla bug 1981634 to target a release in 4.9.0, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.8] bug 1981633: UPSTREAM: : add a way to inject a vulnerable, legacy service-c…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link

deads2k commented Jul 13, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 13, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 13, 2021

@deads2k: This pull request references Bugzilla bug 1981633, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1981498 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1981498 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link

deads2k commented Jul 13, 2021

/hold cancel

proof in master worked

/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2021
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@deads2k deads2k added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Jul 13, 2021
@deads2k
Copy link

deads2k commented Jul 13, 2021

/refresh

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@mfojtik
Copy link
Member

mfojtik commented Jul 14, 2021

/override ci/prow/e2e-aws-upgrade

@openshift-ci
Copy link

openshift-ci bot commented Jul 14, 2021

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/e2e-aws-upgrade

In response to this:

/override ci/prow/e2e-aws-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik mfojtik merged commit f15374c into openshift:release-4.8 Jul 14, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 14, 2021

@openshift-cherrypick-robot: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1981633 has not been moved to the MODIFIED state.

In response to this:

[release-4.8] bug 1981633: UPSTREAM: : add a way to inject a vulnerable, legacy service-c…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants