Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2002808: UPSTREAM: 104314: legacy-cloud-providers: aws: Add support for consuming web identity credentials #927

Merged
merged 1 commit into from Sep 8, 2021

Conversation

sjenning
Copy link

@sjenning sjenning commented Sep 2, 2021

kubernetes#104314

This allows the KCM to use STS creds with web identity role credentials. Needed for full STS on OCP standalone and Hypershift.

xref openshift/hypershift#389

@derekwaynecarr @csrwng

@openshift-ci-robot openshift-ci-robot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Sep 2, 2021
@openshift-ci-robot
Copy link

@sjenning: the contents of this pull request could be automatically validated.

The following commits are valid:

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Sep 2, 2021
@sjenning
Copy link
Author

sjenning commented Sep 2, 2021

/retest

@deads2k
Copy link

deads2k commented Sep 2, 2021

/approve

for master. Upstream took the change in 1.23

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2021
Copy link

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, Fedosin, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2021
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2021

@sjenning: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-agnostic-cmd f60a6d3 link /test e2e-agnostic-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 43892aa into openshift:master Sep 8, 2021
@sjenning sjenning changed the title UPSTREAM: 104314: legacy-cloud-providers: aws: Add support for consuming web identity credentials Bug 2002808: UPSTREAM: 104314: legacy-cloud-providers: aws: Add support for consuming web identity credentials Sep 9, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 9, 2021

@sjenning: All pull requests linked via external trackers have merged:

Bugzilla bug 2002808 has been moved to the MODIFIED state.

In response to this:

Bug 2002808: UPSTREAM: 104314: legacy-cloud-providers: aws: Add support for consuming web identity credentials

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjenning
Copy link
Author

sjenning commented Sep 9, 2021

/cherry-pick release-4.9

@openshift-cherrypick-robot

@sjenning: new pull request created: #944

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants