New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.3] Bug 1799401: Ensure no sg rule is repeated on the Network Policy CRD #159
[release-4.3] Bug 1799401: Ensure no sg rule is repeated on the Network Policy CRD #159
Conversation
When a network policy is updated we compare all the existing sg rules with the current sg rules in order to add/remove rules. When there are existing rules repeated only the first occurence of the rule is identified as to be kept, and the second one is not, causing the rule on the current sg rules to not be created, as it matches an existent sg rule that was not meant to be kept, causing a breakage on the update NP CRD which does not allow sg rules with no ID. This commit fixes the issue by ensuring that no sg rule is repeated on the NP CRD. Closes-bug: 1861624 Change-Id: I5170e0177a87c2dde77f19f6a7ae09ca2a06c65e
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1795631, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1799401, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@luis5tb: This pull request references Bugzilla bug 1799401, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/approved |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: luis5tb, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/bugzilla refresh |
@luis5tb: This pull request references Bugzilla bug 1799401, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1799401 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-sdn: add kube-proxy liveness probe
This is an automated cherry-pick of #158
/assign luis5tb